Repository navigation
fix(rq-kgtp): Dots laid out beside the words stay clear of them after the words scroll - #1110
Merged
Merged
Conversation
… the words scroll AreaNames measured the cards only on mount, resize and relayout, so a scrolled story could move a card over a dot stepped clear of it. It now listens for scroll in the capture phase on its scope and measures again once a frame. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WCDKf2sgVNR7sEgxh9yNgE
Owner
Author
|
Review (cold read, The fix addresses the cause the bead names. The reviewer confirmed in LanternLayout.vue that the stage and
|
Answers review findings 1-3: the test puts the story outside the stage under .lq-main, as the layout does, and stubs requestAnimationFrame; the scroll handler says why it measures while not showing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WCDKf2sgVNR7sEgxh9yNgE
Owner
Author
|
Answers to the review, at
No follow-up review: these are test-only changes plus a doc comment, and none of them changes behaviour. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bead rq-kgtp: with Showing on, scrolling the words left dots under cards.
The bug
AreaNames steps a dot clear of the cards and spoken lines whenever it measures them. It measured on mount, on a resize, and when
relayout/showingchanged, but never when the story scrolled. A scroll could therefore carry a card over a stepped dot (Shelves and Hearth in Elior's Cottage), and a press on the dot hit the words.The fix
AreaNames.vuelistens forscrollin the capture phase on the scope it measures (.lq-main, else the stage) and measures again once per animation frame. It removes the listener and cancels a pending frame on unmount.Reproduction
AreaNames.test.ts, covered things (rq-qz71) › steps a dot clear of the words again when the story scrolls them over it (rq-kgtp): the card moves over the stepped dot and ascrollfires on.lq-story. Before the fix the dot stayed inside the card; it now steps clear again.Validation
Fast gate green locally: eslint, prettier --check, vue-tsc,
npm run test(514 files, 6971 tests). No deviations; a bug bead has no plan, so the reproduction test is the plan.Formatting constraints verified
🤖 Generated with Claude Code
https://claude.ai/code/session_01WCDKf2sgVNR7sEgxh9yNgE