Skip to content

fix(rq-eyan): With Showing on, every name reads in full - #1113

Merged
rmstdope merged 2 commits into
mainfrom
rq-eyan-with-showing-on-every-name-reads-in-full
Nov 12, 2026
Merged

rmstdope merged 2 commits into
mainfrom
rq-eyan-with-showing-on-every-name-reads-in-full

Conversation

@rmstdope

Copy link
Copy Markdown
Owner

Bead rq-eyan. A revealed left-off name now hangs clear of cards, panels and every shown name (nearest clear spot with a leader line); with no clear spot it sits beside its dot and the names it covers (and their lines) fade until it goes.

Validation: eslint, prettier, vue-tsc, npm run test (6977), build all green. Formatting constraints verified.

🤖 Generated with Claude Code

rmstdope and others added 2 commits November 12, 2026 09:25
…he words, and faded names take no press

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WCDKex9h2Nk72i57yN7SR8
@rmstdope

Copy link
Copy Markdown
Owner Author

Review (cold read, reviewed_head: af724b45) — reviewed before merge under the producer's review practice, by an agent given the diff and the bead, and not the producer's reasoning.

  1. Ring search had no reach limit and no check that the leader avoids the words. Fixed: spots must be within NAME_REACH, and the leader may cross no card, panel or name; else the beside-the-dot fallback. Unit test added.
  2. Fade/restore/line not really tested. Fixed: component test makes a name too wide for any clear spot, asserts the covered name and its line get lq-area-faded, the dot stays, and all return on pointer leave; leader asserted in the unit test. Keyboard focus shares the same hangAt path as the pointer; not duplicated.
  3. Ring grid misses narrow gaps. Partly fixed: the search also tries either side level with the dot; the 2px slides stay in the standard tries. Fallback fade remains acceptable per the acceptance.
  4. as PlacedName cast. Fixed: leaderFor takes { x, y }.
  5. Faded names clickable. Fixed: pointer-events: none on .lq-area-faded.
  6. lie typing. Fixed.

@rmstdope
rmstdope merged commit a94f6b0 into main Nov 12, 2026
7 checks passed
@rmstdope
rmstdope deleted the rq-eyan-with-showing-on-every-name-reads-in-full branch November 12, 2026 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant