Skip to content

fix(ios): support static frameworks under Expo SDK 57 precompiled pipeline #4245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfazekas merged 1 commit into from
Jul 5, 2026
+13 −4
Merged

fix(ios): support static frameworks under Expo SDK 57 precompiled pipeline #4245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ios/RNMBX/rnmapbox_maps-Swift.pre.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
@interface MapView : UIView
@end

#if RNMBX_USE_FRAMEWORKS
#if __has_include(<rnmapbox_maps/rnmapbox_maps-Swift.h>)
#import <rnmapbox_maps/rnmapbox_maps-Swift.h>
#else
#import <rnmapbox_maps-Swift.h>
Expand Down
15 changes: 12 additions & 3 deletions rnmapbox-maps.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,19 @@ end

$rnMapboxMapsTargetsToChangeToDynamic = rnMapboxMapsTargetsToChangeToDynamic

def $RNMapboxMaps._expo_precompiled_pipeline?
# Expo SDK 56+ precompiled iOS pipeline (prebuilt React core) downgrades every
# framework-style pod back to a static library after the podspec is evaluated.
# Flipping the Mapbox pods to dynamic here fights that and leaves an inconsistent
# graph (MapboxMaps stays dynamic while its deps get forced static). See #4242.
ENV['EXPO_USE_PRECOMPILED_MODULES'] == '1'
end

def $RNMapboxMaps.pre_install(installer)
if $RNMapboxMaps._expo_precompiled_pipeline?
Pod::UI.puts "[RNMapbox] Expo precompiled modules pipeline detected (EXPO_USE_PRECOMPILED_MODULES=1) — skipping the Mapbox dynamic-framework flip so all Mapbox pods stay consistently static."
return
end
installer.aggregate_targets.each do |target|
target.pod_targets.select { |p| $rnMapboxMapsTargetsToChangeToDynamic.include?(p.name) }.each do |mobile_events_target|
mobile_events_target.instance_variable_set(:@build_type,Pod::BuildType.dynamic_framework)
Expand Down Expand Up @@ -286,9 +298,6 @@ Pod::Spec.new do |s|
$RNMapboxMaps._add_compiler_flags(sp, "-DRNMBX_RN_72=1")
end
end
if ENV['USE_FRAMEWORKS'] || $RNMapboxMapsUseFrameworks
$RNMapboxMaps._add_compiler_flags(sp, "-DRNMBX_USE_FRAMEWORKS=1")
end
else
fail "$RNMapboxMapsImpl should be mapbox but was: $RNMapboxMapsImpl"
end
Expand Down
Loading