Repository navigation
spec: roll up to Agent CLI Guidelines v0.4.0 - #2
Merged
Merged
Conversation
Add a machine-verifiable conformance block to `rivr schema` and pin the
README conformance to v0.4.0 Full.
- version: add `const Spec = "0.4.0"`
- schema: emit `conformance` { spec, version, level: Full }
- README: pin badge + add a Conformance statement
- regenerate schema golden
Backpressure for the scraped Amazon backend is already present and wired:
internal/throttle is a persistent, cross-process circuit-breaker
(load/block/clear via internal/provider/common.go), so no throttle work
is needed in this PR.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012UFrhC6bXVpoiiL3yhj2HH
There was a problem hiding this comment.
Pull request overview
Updates rivr to conform to Agent CLI Guidelines v0.4.0 (Full) by making the conformance version machine-verifiable at runtime via the schema JSON output, and aligning repository documentation and schema snapshot expectations accordingly.
Changes:
- Add
internal/version.Spec = "0.4.0"to represent the conformance spec version. - Extend
rivr schemaJSON output with a top-levelconformanceblock referencingversion.Spec. - Update README to pin conformance messaging to v0.4.0 and regenerate the schema golden snapshot.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Pins conformance messaging to v0.4.0 (Full) and documents the machine-verifiable conformance block. |
| internal/version/version.go | Introduces Spec constant (0.4.0) for the conformance version source of truth. |
| internal/cli/misc.go | Emits conformance in the schema JSON output using version.Spec. |
| internal/cli/testdata/schema.golden.json | Updates schema snapshot golden to include the new conformance block. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+138
to
+141
| rivr conforms to the [Agent CLI Guidelines](https://aclig.dev/) **v0.4.0** at the **Full** | ||
| level. The contract version is machine-verifiable from the binary — `rivr schema` emits a | ||
| `conformance` block (`{ spec: "agent-cli-guidelines", version: "0.4.0", level: "Full" }`), | ||
| so an agent can confirm the standard it was built against without trusting this README. |
- README: rewrite the conformance example as a valid JSON fenced block (was a JS object literal with bare keys), matching `rivr schema` output. - update: send a User-Agent on the version-check request (GitHub's REST API rejects UA-less requests) and surface non-200 responses as errors; aligns with the examplectl Go version-check idiom. Add a test asserting the User-Agent is sent. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012UFrhC6bXVpoiiL3yhj2HH
Owner
Author
|
Addressed the review:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rolls rivr up to Agent CLI Guidelines v0.4.0 (Full).
Per-rule checklist
schema—rivr schema --jsonnow emitsconformance: { spec: "agent-cli-guidelines", version: "0.4.0", level: "Full" }, generated fromversion.Spec. Mirrors the examplectl Go idiom (contract §5: machine-readable conformance).const Spec = "0.4.0"added tointernal/version.version --check— already present (pull-based, fail-silent viainternal/update); no change needed.internal/throttleis a persistent, cross-process circuit-breaker (Load/Block/Clear/RetryAfter), wired throughinternal/provider/common.go(throttle.Load(...).RetryAfter,markBlocked→throttle.Block,markOK→throttle.Clear) and surfaced viadoctor/Cooldown. No throttle built in this PR (none needed).v0.4.0, plus a new Conformance section stating the spec version + level and pointing at the binary-verifiableschemablock.internal/cli/testdata/schema.golden.json).Verification
go build ./...— cleango test ./...— 39 passed in 12 packagesrivr schema --jsonemits the conformance block at runtime (confirmed)Resulting level
Full @ Agent CLI Guidelines v0.4.0
🤖 Generated with Claude Code
https://claude.ai/code/session_012UFrhC6bXVpoiiL3yhj2HH