fix: bump verify-signed-commit-authors pin past allowed_signers fixes#37
Merged
Merged
Conversation
The action pin at 088d5c5 predates the allowed_signers updates that followed it — notably #33 (arv's corrected public key) and the newer team keys — so the required workflow verified signatures against a stale 4-entry allowlist and rejected validly signed commits (e.g. rocicorp/mono#6231). Pin to current main (2e20374) which bundles the up-to-date allowed_signers. Note: any future edit to allowed_signers needs a matching pin bump here to take effect.
arv
requested review from
0xcadams,
aboodman,
cesara,
darkgnotic,
grgbkr and
tantaman
as code owners
July 14, 2026 10:51
There was a problem hiding this comment.
Pull request overview
Updates the pinned revision of the internal verify-signed-commit-authors GitHub Action used by the required “signed commit authors” workflow so signature verification uses the latest allowed_signers list and stops rejecting validly signed commits.
Changes:
- Bump the
rocicorp/.github/.github/actions/verify-signed-commit-authorsaction pin from088d5c5d…to2e203740….
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
arv
enabled auto-merge
July 14, 2026 12:17
arv
disabled auto-merge
July 14, 2026 12:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The action pin at
088d5c5dpredates theallowed_signersupdates that followed it — notably #33 (arv's corrected public key) and the newer team keys — so the required workflow verified signatures against a stale 4-entry allowlist and rejected validly signed commits (first hit: rocicorp/mono#6231, failing with "signature is not made by an allowed SSH signing key" despite a Good signature matching the current allowlist).This bumps the pin to current main (
2e203740), which bundles the up-to-dateallowed_signers.Worth noting for follow-up: with a SHA pin, every future edit to
allowed_signerssilently does nothing until the pin here is bumped too. Options: pin this action to a moving ref (it's same-org, so the usual third-party-pinning concern doesn't apply), or add a check in this repo that fails when the pin lags the allowlist.🤖 Generated with Claude Code