Skip to content

Fix batch examples reading .outputs from batch results - #90

Open
jadenfix wants to merge 1 commit into
roe-ai:mainfrom
jadenfix:fix/examples
Open

jadenfix wants to merge 1 commit into
roe-ai:mainfrom
jadenfix:fix/examples

Conversation

@jadenfix

@jadenfix jadenfix commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

JobBatch.wait() returns AgentJobResultItem objects, whose outputs are in .result (nullable), not .outputs. examples/run_agent_many.py and the batch example in examples/run_agent_with_timeout.py raised AttributeError once jobs finished. This matches the batch example in SDK_EXAMPLES.md.

Testing

  • ruff check / ruff format --check on examples/.
  • Checked the field names against roe._generated.models.agent_job_result_item.

Testing against the live API requires a Roe API key, so these were verified with unit tests and local mock servers only.

Related issues (behaviour changes discussed separately, not changed here): #85, #86, #87, #88

JobBatch.wait() returns AgentJobResultItem objects, whose outputs
are in .result (nullable), not .outputs, so both examples raised
AttributeError once the jobs finished. Matches the batch example in
SDK_EXAMPLES.md.

Tested: ruff check/format on examples/; confirmed the field names in
roe._generated.models.agent_job_result_item. Running the examples
needs a Roe API key.
@greptile-apps

greptile-apps Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

Both batch examples now read outputs from AgentJobResultItem.result instead of the nonexistent .outputs field.

  • Batch examples print outputs from each job result.

Reviews (1) · Last reviewed commit: "Fix batch examples reading .outputs from..." · Reviewed by Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant