Flag path-like codes in diagnosticFilters - #1753
Open
markwpearce wants to merge 4 commits into
Open
Conversation
Warn when a v1-style diagnosticFilters entry looks like a file path or glob (contains `./`, `../`, `**`, or ends in `.bs`/`.brs`/`.xml`) instead of a diagnostic code, since that's a common leftover from migrating a v0-style config. Skipped when diagnosticFiltersV0Compatibility is enabled, since those filters are legitimately file globs. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
TwitchBronBron
requested changes
Jul 31, 2026
| } | ||
| const lowerValue = value.toLowerCase(); | ||
| return ( | ||
| value.includes('./') || |
| * This is a common mistake when migrating a bsconfig.json from the v0-style filters (which were file globs) | ||
| */ | ||
| public detectPathLikeDiagnosticFilterCodes(config: FinalizedBsConfig, context?: DiagnosticContext) { | ||
| const pathLikeCodes = this.diagnosticFilterer.getPathLikeDiagnosticFilterCodes(config); |
Member
There was a problem hiding this comment.
Might be worth checking to see if the pattern is exactly a path to a known file in the files array? like source/main.json or something?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
diagnosticFiltersentry looks like a file path or glob (contains./,../,**, or ends in.bs/.brs/.xml) rather than a diagnostic code — a common mistake when migrating a v0-style bsconfig, wherediagnosticFiltersentries were file globs.diagnosticFiltersV0Compatibilityis enabled, since those filters are legitimately file globs.Closes #1384
Test plan
DiagnosticFilterer.getPathLikeDiagnosticFilterCodesProgram.spec.tsverifying the diagnostic is emitted/not emitted duringprogram.validate()npm run build,npm run lint, andnpm run test:nocoverall pass🤖 Generated with Claude Code