Draft Support for Very Large Collection#21852
Draft
pcanal wants to merge 31 commits into
Draft
Conversation
pcanal
requested review from
bellenot,
dpiparo,
jblomer and
linev
as code owners
Test Results 20 files 20 suites 3d 5h 19m 53s ⏱️ For more details on these failures, see this check. Results for commit 2e2c703. ♻️ This comment has been updated with latest results. |
pcanal
force-pushed
the
very_large_collection
branch
from
2919c36 to
c364f50
Compare
pcanal
force-pushed
the
very_large_collection
branch
6 times, most recently
from
6891a9f to
f3f405d
Compare
pcanal
force-pushed
the
very_large_collection
branch
4 times, most recently
from
c8692de to
59db0dc
Compare
Support the case where the class information is passed by name rather than by TClass pointer (eg. the action ReadCollectionDouble32)
In TBufferFile::ReadClass properly set the byte count returned to kOverflowCount when the byte count in the stream was not updated (was too large).
It is staying signed for historical reason since we do not plan to support collection larger than std::numeric_limit<std::int64_t>::max() as onfile we reserve the sign bit as a marker.
NOTE: this might be backward incompatible
The change in TStreamerInfo class version changes the compressed size of the TStreamerInfo record in the file.
The change in TStreamerInfo class version changes the compressed size of the TStreamerInfo record in the file. In this test, the file is updated/added-to, consequently the keys/baskets that are written after the first TStreamerInfo record are moved slightly and this changes the compressed size of the TTree object on file.
This is use in particular for TClass to register the upcoming object type.
pcanal
force-pushed
the
very_large_collection
branch
2 times, most recently
from
b5f2099 to
2e2c703
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not ready for review -- just running the CI for a checkpoint.