[ntuple] Add schema profile visualizator backend supporting Speedscope#22641
[ntuple] Add schema profile visualizator backend supporting Speedscope#22641albfsg wants to merge 1 commit into
Conversation
albfsg
force-pushed
the
flame_visualizer_backend
branch
from
22e1cd4 to
42fcc76
Compare
|
Images of how Speedscope renders the output of the method as a left-heavy view and a sandwich view: 
|
|
Images of how Speedscope renders the output of the method for the test ntuple as a left-heavy view and a sandwich view: 
|
silverweed
left a comment
silverweed
left a comment
There was a problem hiding this comment.
Thank you! This is already in a very good state, I mostly have minor comments about it.
| /// | ||
| /// \param[in] format The output format for the flamegraph specification (right now only supports Speedscope's JSON) | ||
| /// | ||
| void PrintFieldTreeAsFlamegraphSpecification(EFlamegraphSpecificationFormat format, |
There was a problem hiding this comment.
I'm unsure whether to call it "Flamegraph", as it's more of a profile viewer...we might want to just name this method something like PrintSchemaAsProfile / PrintSchemaProfile.
@jblomer any suggestion?
There was a problem hiding this comment.
I have no strong opinion on either of the two terms.
There was a problem hiding this comment.
I've updated the signature to PrintSchemaProfile.
|
Replaces #4634 |
albfsg
changed the title
|
@albfsg did you forget to push? I see you resolved several comments but they are still unaddressed in this PR |
I didn't forget. I resolved them locally and just haven't pushed it yet because I have a few doubts I'd like to discuss in person before pushing the changes. Although I see why it's confusing to close them before actually pushing anything. |
I see. I recommend resolving the comments only after pushing the changes (if you want to mark them for your own local usage you can e.g. thumb-up them) |
OK Thanks! |
Produces an output readable by performance profile viewers, as of this commit just Speedscope, to visualize the fields of an ntuple and the columns below them. Comes with a unit test in ntuple_inspector.
albfsg
force-pushed
the
flame_visualizer_backend
branch
from
6dafd69 to
b36b343
Compare
3 participants
This Pull request:
Changes:
This PR adds
void PrintSchemaProfile(ESchemaProfileFormat format, std::ostream &output = std::cout) const;method to theRNTupleInspectorclass.It also adds a trivial unit test to the
ntuple_inspector.cxxfile which locally works.Checklist:
ntuple_inspectorfile tests.