Skip to content

[build] Migrate build backend to scikit-build-core#22645

Open
jase231 wants to merge 2 commits into
root-project:masterfrom
jase231:jserwe_scikit_build_core
Open

[build] Migrate build backend to scikit-build-core#22645
jase231 wants to merge 2 commits into
root-project:masterfrom
jase231:jserwe_scikit_build_core

Conversation

@jase231

@jase231 jase231 commented Jun 17, 2026

Copy link
Copy Markdown

This Pull request:

Migrates the Python build backend from setuptools to scikit-build-core, which is built for CMake. This change entirely eliminates the need for setup.py, moving all wheel build config into pyproject.toml.

Changes or fixes:

  • Replaced setuptools with scikit-build-core
    • Wheel-specific config and defines are now passed directly to the build system in pyproject.toml thanks to scikit-build-core's CMake integration
  • Moves alpha version warning into a version-conditional check in __init__.py to avoid injecting the warning code at build time
  • Increases the ROOT wheel distribution's version to 0.1a14
  • Fixes several issues that made linking against the wheel-provided ROOT installation challenging:
    • Eliminates the mock_site_packages paths that previously ended up hardcoded into CMake configs
    • Fixes mysterious missing PCM errors

Checklist:

  • tested changes locally (successfully produced wheels and ran AGC without issue)
  • updated the docs (not necessary as far as I can tell)

@vepadulano vepadulano added the build-python-wheels Run the workflow to build Python wheels label Jun 17, 2026
@vepadulano vepadulano requested a review from siliataider June 17, 2026 12:59
@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown

Test Results

    22 files      22 suites   3d 16h 12m 58s ⏱️
 3 870 tests  3 869 ✅ 0 💤 1 ❌
77 347 runs  77 346 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit e2bed75.

♻️ This comment has been updated with latest results.

@jase231 jase231 force-pushed the jserwe_scikit_build_core branch from 72ee658 to 20e4743 Compare June 18, 2026 11:40
@jase231 jase231 force-pushed the jserwe_scikit_build_core branch from 20e4743 to e2bed75 Compare June 19, 2026 14:53

@siliataider siliataider left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for this solid structural change 🎉 This eliminates a whole class of path/linking issues already paving the way for the next wheel-related work items, well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build-python-wheels Run the workflow to build Python wheels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants