[build] Migrate build backend to scikit-build-core#22645
Open
jase231 wants to merge 2 commits into
Open
Conversation
Test Results 22 files 22 suites 3d 16h 12m 58s ⏱️ For more details on these failures, see this check. Results for commit e2bed75. ♻️ This comment has been updated with latest results. |
72ee658 to
20e4743
Compare
20e4743 to
e2bed75
Compare
siliataider
approved these changes
Jun 19, 2026
siliataider
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thank you for this solid structural change 🎉 This eliminates a whole class of path/linking issues already paving the way for the next wheel-related work items, well done!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Migrates the Python build backend from
setuptoolstoscikit-build-core, which is built for CMake. This change entirely eliminates the need for setup.py, moving all wheel build config intopyproject.toml.Changes or fixes:
setuptoolswithscikit-build-corepyproject.tomlthanks toscikit-build-core's CMake integration__init__.pyto avoid injecting the warning code at build time0.1a14mock_site_packagespaths that previously ended up hardcoded into CMake configsChecklist: