Repository navigation
chore: prepare v0.4.6 release and fix deb build - #41
Merged
Merged
Conversation
- Make 'deb' fail on dpkg-buildpackage errors instead of exiting 0 - Remove debian/rules dh_builddeb override that moved the .ddeb out of the path dpkg-genbuildinfo expects; deb target now moves packages to dist/packages after the build - Bump version to 0.4.6 in Makefile, main.go and debian/changelog - Fix release.sh so it updates main.go (matches 'version = "v..."') - Add CHANGELOG entry for v0.4.6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make debnow fails ondpkg-buildpackageerrors instead of exiting 0 (previously masked a failed build during the v0.4.5 release)debian/rulesdh_builddeboverride that moved the.ddebout of the pathdpkg-genbuildinfochecks;make debnow moves packages todist/packagesafter the buildMakefile,main.goanddebian/changelog(v0.4.5 already exists, and packaging was still at 0.4.4)release.shnow updatesmain.go(the old pattern didn't matchversion = "v...")Not in this PR
.github/workflows/release.yml: moving the test and gosec steps ahead of the image push and.debupload is still outstanding. It is not committed.Testing
go test -count=1 ./...passesgolangci-lint run --no-configreports 0 issuesmake debbuildsbucketsyncd_0.4.6-1_amd64.debandbucketsyncd-dbgsym_0.4.6-1_amd64.ddebintodist/packagesmain.goline; release.sh itself was not run