Repository navigation
ci: publish release from a single job - #44
Merged
Merged
Conversation
Both matrix jobs created the GitHub release, pushed the same image tags and uploaded the same binaries, which raced and logged 'error updating release asset metadata' for every shared asset. build (matrix): test, gosec, make deb; amd64 builds the binaries. Each job uploads its packages as an artifact. publish (needs build): downloads artifacts, pushes the image, creates the release once and uploads the debs once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
error updating release asset metadatafor each shared asset. All assets ended up present, but the race is in the workflow.build(matrix): tests, gosec,make deb. The amd64 job also builds the binaries. Each job uploads its packages as an artifact.publish(needsbuild, one runner): downloads the artifacts, builds and pushes the image, creates the release once, and uploads the debs once.Testing
actionlintshows the same three shellcheck info notes thatmasteralready has. No new findings.actions/upload-artifact@v7,actions/download-artifact@v8(latest at time of writing).