Skip to content

Set abortOnError=true and clean up related lint note (#98) #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rossigee merged 1 commit into from
Oct 6, 2026
Merged

Set abortOnError=true and clean up related lint note (#98) #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pr-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
uses: ./.github/actions/summarise-lint
with:
report-path: ${{ env.MODULE }}/build/reports/lint-results-debug.xml
note: Lint is configured with abortOnError false, so these do not block the pull request.
note: Lint errors now fail the build (abortOnError=true).

- name: APK size check
run: |
Expand Down
2 changes: 1 addition & 1 deletion sms2webhook/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ android {
}

lint {
abortOnError = false
abortOnError = true
}
namespace = 'org.golder.sms2webhook'

Expand Down
2 changes: 1 addition & 1 deletion sms2webhook/src/main/java/org/golder/sms2webhook/LogAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public boolean areItemsTheSame(@NonNull MainViewModel.LogEntry oldItem, @NonNull

@Override
public boolean areContentsTheSame(@NonNull MainViewModel.LogEntry oldItem, @NonNull MainViewModel.LogEntry newItem) {
return oldItem.type == newItem.type;
return oldItem.type.equals(newItem.type);
}
});
this.context = context;
Expand Down
Loading