Add --additionalParameterJSON to agents import and tools import - #64
Merged
Conversation
Sends request fields the CLI has no flag for. Each value is a JSON dict or
the name of a file containing one; the flag is repeatable and all the dicts
are merged before the POST.
A value starting with '{' is the document itself, anything else is a
filename, so a misspelled path reports a missing file rather than a JSON
syntax error in text the user meant as a path. Merging is shallow and
last-wins by top-level key, which lets a later value replace a nested
structure an earlier one set. Keys naming a field the other flags populate
override them.
The overlay is applied in MarshalJSON, on the encoded request rather than
the struct: that is where the JSON names exist, it makes the omitempty
fields settable, and it catches --storage-size, which is assigned after the
request literal is built. Client signatures are unchanged. With no
additional parameters the encoding is byte-identical to before.
Assisted by Claude.
Signed-off-by: Ed Snible <snible@us.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sends request fields the CLI has no flag for. Each value is a JSON dict or the name of a file containing one; the flag is repeatable and all the dicts are merged before the POST.
{is the document itself, anything else is a filename, so a misspelled path reports a missing file rather than a JSON syntax error.--storage-sizeand--portsincluded.Applied in
MarshalJSONon the encoded request, so client signatures are unchanged and a request without the flag encodes byte-identically to before.Assisted by Claude.