Register the sparc plugin on every architecture - #70
Merged
Conversation
Renames cmd/authbridge_plugin_sparc.go to authbridge_plugin_sparcplugin.go. "sparc" is one of the architecture names Go recognizes in its implicit filename constraint, so a file ending in _sparc.go is constrained to GOARCH=sparc and excluded everywhere else. The file landed in `go list`'s IgnoredGoFiles, the blank import never ran, and `authbridge exec` reported `unknown plugin "sparc"` on amd64 and arm64 alike. The //go:build !exclude_plugin_sparc line was dead: the file name is applied first. The new suffix matches cortex's own cmd/authbridge-proxy/plugins_sparcplugin.go. Confirmed before and after: the registered list goes from eleven plugins to twelve, and a config naming sparc now fails on its own required field (reflector_endpoint) rather than on the plugin being absent. -tags exclude_plugin_sparc still drops it, which it could not meaningfully do before. Assisted by Claude. Signed-off-by: Ed Snible <snible@us.ibm.com>
esnible
force-pushed
the
fix-sparc-plugin-filename
branch
from
August 17, 2026 20:24
b958e8d to
ad36386
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #68.
Renames
cmd/authbridge_plugin_sparc.gotoauthbridge_plugin_sparcplugin.go.sparcis one of the architecture names Go recognizes in its implicit filename constraint, so the old name constrained the file toGOARCH=sparcand excluded it everywhere else. It landed ingo list'sIgnoredGoFiles, the blank import never ran, and the//go:build !exclude_plugin_sparcline was dead — the filename is applied first. The new suffix matches cortex's owncmd/authbridge-proxy/plugins_sparcplugin.go.Before and after, on arm64:
-tags exclude_plugin_sparcstill drops it — which it could not meaningfully do before.Note that nothing fails at build time when this regresses: the misnamed file compiles cleanly and passes
go vet, and the only symptom isunknown plugin "sparc"at run time. The comment in the renamed file explains why the suffix differs from its siblings.Assisted by Claude.