Fix Sidekiq::Job::Setter#at type - #1065
Merged
github-actions[bot] merged 1 commit intoSep 2, 2026
Merged
Conversation
akitoshiga
force-pushed
the
fix/sidekiq-deprecated-float-type
branch
from
September 2, 2026 08:14
b66040b to
bede040
Compare
akitoshiga
changed the title
akitoshiga
force-pushed
the
fix/sidekiq-deprecated-float-type
branch
from
September 2, 2026 08:16
bede040 to
8b547ad
Compare
The top-level `float` alias is deprecated in RBS 4. Use `_ToF`, which preserves the accepted argument type without producing a validation warning.
akitoshiga
force-pushed
the
fix/sidekiq-deprecated-float-type
branch
from
September 2, 2026 08:16
8b547ad to
5a8ab14
Compare
akitoshiga
marked this pull request as ready for review
September 2, 2026 08:17
|
@akitoshiga Thanks for your contribution! Please follow the instructions below for each change. Available commandsYou can use the following commands by commenting on this PR.
|
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The top-level
floatalias is deprecated in RBS 4. This PR replaces it with_ToF, preserving the accepted argument type without producing a validation warning.Sidekiq::Job::Setter#atconverts the value with#to_f:https://github.com/sidekiq/sidekiq/blob/7df28434f03fa1111e9e2834271c020205369f94/lib/sidekiq/job.rb#L254-L260
I've confirmed
bin/test gems/sidekiq/7.0passes with this change.