Repository navigation
Conversation
A KIND column in instances list and instances types, and Kind in instances info, read from the API's deployment_type. Refs: RUN-625
instances list and types gain a HOST column (Datacenter or Community, from the API's host_tier; absent reads as Datacenter), instances info a Host line. types and create take --include-community: community hosts are listed and launched only when asked for, as the API does. Job schedules refuse the flag. Also puts stopReasonText's doc comment back on it. Refs: RUN-625
heydryft
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the machine's kind and who hosts it to the instance views. Pairs with runcrate_app #303 (container machine kind and community host tier, RUN-625).
instances listandinstances types: KIND (VM, Bare metal, Container, fromdeployment_type; anything else shown as sent, nothing as -) and HOST (Datacenter or Community, fromhost_tier; absent reads as Datacenter, since every machine before community hosts ran in one).instances info:Kind:andHost:lines.instances types --include-communityandinstances create --include-community(also on instance schedules): community hosts are listed and launched only when asked for, as the API does (?include_community=true, bodyinclude_community: true). Job schedules refuse the flag.Proof:
go vet ./...andgo test ./...green (TestListInstanceTypes now checks community types appear only with the opt-in). Smoke against a fake API: list showed Datacenter / Community / Datacenter (absent host_tier), types without the flag listed only the datacenter type and with it both, info printedHost: Community, and create sent"include_community":true.Refs: RUN-625