Accept "try-jobs:" as alternative to "try-job:"

[RalfJung]

As part of the bors command, both try job=foo and try jobs=foo work. However, I just found out the hard way that when specifying the jobs via the PR description, only "try-job:" works, not "try-jobs:".

Would be great to make this consistent and reduce some potential confusion. :)

[Kobzol]

I only added try job= because people were writing it by accident instead of try jobs= 😆 I guess what you describe is the same situation though..

[RalfJung]

Oh so originally it was try-job and "bors try jobs"? Yeah well not surprising that people end up confused about the trailing s ;) Though I wonder, is the syntax the same? Does the PR description declaration support ","? It might be good if it would.

[Kobzol]

As far as I'm concerned, the two things aren't actually related that much.

try-job: is a special marker syntax interpreted by Rust's CI, and existed before bors was even used as the merge bot for rust-lang/rust. This syntax does not accept commas, multiple markers have to be entered on separate lines.

Originally, it was used like this:

try-job: job-1
try-job: job-2

etc. But later we also added glob support, so you can now also say things like try-job: test-*, which makes using multiple markers a bit less common.

@bors try jobs= is the syntax of a bors command that will just generate the try-job: markers for you. Most people use the bors command nowadays, without modifying the PR description (though it can be useful if you do a lot of try builds and don't want to type the jobs repeatedly).

But those are two separate systems, where bors conforms to the syntax expected by the rust-lang/rust CI. Of course that doesn't mean that we can't change the CI markers to also accept try-jobs:.

[RalfJung]

I understand they are implemented entirely separately, but as a user they feel like two entry points to the same thing.

[Kobzol]

rust-lang/rust#163433 + #863 implements this.