Skip to content

ci: Re-enable the musl build on windows-gnu - #1025

Closed
tgross35 wants to merge 3 commits into
rust-lang:mainfrom
tgross35:test-musl-build-ci
Closed

ci: Re-enable the musl build on windows-gnu#1025
tgross35 wants to merge 3 commits into
rust-lang:mainfrom
tgross35:test-musl-build-ci

Conversation

@tgross35

@tgross35 tgross35 commented Sep 25, 2025

Copy link
Copy Markdown
Member

ci: test-libm

@rustbot

This comment has been minimized.

@tgross35
tgross35 force-pushed the test-musl-build-ci branch 2 times, most recently from 1a681b5 to 3c50512 Compare August 12, 2026 19:29
@tgross35 tgross35 changed the title Re-enable the musl build on windows-gnu ci: Re-enable the musl build on windows-gnu Aug 12, 2026
@tgross35
tgross35 marked this pull request as ready for review August 12, 2026 19:29
@tgross35
tgross35 enabled auto-merge (rebase) August 12, 2026 19:29
@tgross35 tgross35 changed the title ci: Re-enable the musl build on windows-gnu ci: Re-enable the musl build on windows-gnu and ppc64le Aug 12, 2026
@tgross35
tgross35 force-pushed the test-musl-build-ci branch from 59f04ef to 3c50512 Compare August 12, 2026 19:47
@tgross35 tgross35 changed the title ci: Re-enable the musl build on windows-gnu and ppc64le ci: Re-enable the musl build on windows-gnu Aug 12, 2026
@rustbot

This comment has been minimized.

@rustbot

rustbot commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@tgross35

tgross35 commented Sep 3, 2026

Copy link
Copy Markdown
Member Author

The build+run works but shows a bunch of failures like:

        thread 'musl_edge_case_expf' (1728) panicked at libm-test\tests\compare_built_musl.rs:26:50:
        called `Result::unwrap()` on an `Err` value:
          input:    (0.0,)
          as hex:   (+0x0p+0,)
          as bits:  (0x00000000,)
          expected: 0.0                 +0x0p+0   0x00000000
          actual:   1.0                 +0x1.000000p+0   0x3f800000

        thread 'musl_edge_case_ceil' (1964) panicked at libm-test\tests\compare_built_musl.rs:26:50:
        called `Result::unwrap()` on an `Err` value:
          input:    (1.0000000000000002,)
          as hex:   (+0x1.0000000000001p+0,)
          as bits:  (0x3ff0000000000001,)
          expected: 1.0                 +0x1.0000000000000p+0   0x3ff0000000000000
          actual:   2.0                 +0x1.0000000000000p+1   0x4000000000000000

I don't think it's worth pursuing.

@tgross35 tgross35 closed this Sep 3, 2026
auto-merge was automatically disabled September 3, 2026 05:29

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants