Skip to content
Navigation Menu
Sign in
Appearance settings
Platform
AI CODE CREATION
GitHub Copilot
Write better code with AI
GitHub Copilot app
Direct agents from issue to merge
MCP Registry
Integrate external tools
DEVELOPER WORKFLOWS
Actions
Automate any workflow
Codespaces
Instant dev environments
Issues
Plan and track work
Code Review
Manage code changes
Code Quality
Enforce quality at merge
APPLICATION SECURITY
GitHub Advanced Security
Find and fix vulnerabilities
Code security
Secure your code as you build
Secret protection
Stop leaks before they start
EXPLORE
Why GitHub
Documentation
Blog
Changelog
Marketplace
View all features
Solutions
BY COMPANY SIZE
Enterprises
Small and medium teams
Startups
Nonprofits
BY USE CASE
App Modernization
DevSecOps
DevOps
CI/CD
View all use cases
BY INDUSTRY
Healthcare
Financial services
Manufacturing
Government
View all industries
View all solutions
Resources
EXPLORE BY TOPIC
AI
Software Development
DevOps
Security
View all topics
EXPLORE BY TYPE
Customer stories
Events & webinars
Ebooks & reports
Business insights
GitHub Skills
SUPPORT & SERVICES
Documentation
Customer support
Community forum
Trust center
Partners
View all resources
Open Source
COMMUNITY
GitHub Sponsors
Fund open source developers
PROGRAMS
Security Lab
Maintainer Community
GitHub Stars
Archive Program
REPOSITORIES
Topics
Trending
Collections
Enterprise
ENTERPRISE SOLUTIONS
Enterprise platform
AI-powered developer platform
AVAILABLE ADD-ONS
GitHub Advanced Security
Enterprise-grade security features
Copilot for Business
Enterprise-grade AI features
Premium Support
Enterprise-grade 24/7 support
Pricing
Search
/
Sign in
Sign up
Appearance settings
You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
Dismiss alert
{{ message }}
rust-lang
rust-clippy
Repository navigation
Code
Issues
2.5k
(2.5k)
Pull requests
362
(362)
Discussions
Actions
Projects
Wiki
Security and quality
Insights
More
items
Rollup of 12 pull requests
- #5432
#5432
Closed
flip1995
wants to merge 55 commits into
rust-lang:master
rust-lang/rust-clippy:master
from
flip1995:rollup-9bj28lr
flip1995/rust-clippy:rollup-9bj28lr
Copy head branch name to clipboard
Conversation
Commits
55
(55)
Checks
Files changed
Closed
Rollup of 12 pull requests
#5432
flip1995
wants to merge 55 commits into
rust-lang:master
rust-lang/rust-clippy:master
from
flip1995:rollup-9bj28lr
flip1995/rust-clippy:rollup-9bj28lr
Copy head branch name to clipboard
Commits
Commits on Mar 20, 2020
Add lint when comparing floats in an array
Show description for 5f1bb72
briankabiro
authored and
marcin-serwin
committed
5f1bb72
View commit details
Copy full SHA for 5f1bb72
Browse repository at this point
Add tests for float in array comparison
briankabiro
authored and
marcin-serwin
committed
b53bcc7
View commit details
Copy full SHA for b53bcc7
Browse repository at this point
Update field names in is_float
marcin-serwin
committed
e91f5b2
View commit details
Copy full SHA for e91f5b2
Browse repository at this point
Update stderr of float_cmp test
marcin-serwin
committed
0f9a0f8
View commit details
Copy full SHA for 0f9a0f8
Browse repository at this point
Add handling of float arrays to miri_to_const
marcin-serwin
committed
b630644
View commit details
Copy full SHA for b630644
Browse repository at this point
Handle evaluating constant index expression
marcin-serwin
committed
0766002
View commit details
Copy full SHA for 0766002
Browse repository at this point
Allow for const arrays of zeros
marcin-serwin
committed
74f5090
View commit details
Copy full SHA for 74f5090
Browse repository at this point
Don't show comparison suggestion for arrays
marcin-serwin
committed
bce1293
View commit details
Copy full SHA for bce1293
Browse repository at this point
Handle constant arrays with single value
marcin-serwin
committed
4165236
View commit details
Copy full SHA for 4165236
Browse repository at this point
Add float cmp tests for arrays
marcin-serwin
committed
517fa65
View commit details
Copy full SHA for 517fa65
Browse repository at this point
Add float cmp const tests for arrays
marcin-serwin
committed
1a7bddb
View commit details
Copy full SHA for 1a7bddb
Browse repository at this point
Commits on Apr 3, 2020
Downgrade let_unit_value to pedantic
dtolnay
committed
adcaa1b
View commit details
Copy full SHA for adcaa1b
Browse repository at this point
Downgrade trivially_copy_pass_by_ref to pedantic
dtolnay
committed
94154ca
View commit details
Copy full SHA for 94154ca
Browse repository at this point
Downgrade inefficient_to_string to pedantic
dtolnay
committed
e26ae7a
View commit details
Copy full SHA for e26ae7a
Browse repository at this point
Clean up update_lints
flip1995
committed
ffb2e41
View commit details
Copy full SHA for ffb2e41
Browse repository at this point
Get rid of Lint::is_internal method
flip1995
committed
da67982
View commit details
Copy full SHA for da67982
Browse repository at this point
Build lint lists once and the reuse them to update files
flip1995
committed
98c30fe
View commit details
Copy full SHA for 98c30fe
Browse repository at this point
Don't filter lints in code generation functions
flip1995
committed
a186d9f
View commit details
Copy full SHA for a186d9f
Browse repository at this point
Make lint modules private
flip1995
committed
d89bb50
View commit details
Copy full SHA for d89bb50
Browse repository at this point
Run update_lints
flip1995
committed
045722a
View commit details
Copy full SHA for 045722a
Browse repository at this point
Move matches test in matches module
flip1995
committed
30503a9
View commit details
Copy full SHA for 30503a9
Browse repository at this point
Commits on Apr 4, 2020
result_map_or_into_option: add lint to catch manually adpating Result -> Option
Show description for 91d8a80
nickrtorres
committed
91d8a80
View commit details
Copy full SHA for 91d8a80
Browse repository at this point
Rename rustc -> rustc_middle in doc links
flip1995
committed
2481d3c
View commit details
Copy full SHA for 2481d3c
Browse repository at this point
Update CONTRIBUTING.md
flip1995
committed
fac5a41
View commit details
Copy full SHA for fac5a41
Browse repository at this point
Downgrade unreadable_literal to pedantic
dtolnay
committed
be34bc4
View commit details
Copy full SHA for be34bc4
Browse repository at this point
Downgrade new_ret_no_self to pedantic
dtolnay
committed
560c8c9
View commit details
Copy full SHA for 560c8c9
Browse repository at this point
result_map_or_into_option: explicitly note absence of known problems
nickrtorres
committed
91759a7
View commit details
Copy full SHA for 91759a7
Browse repository at this point
result_map_or_into_option: add good and bad examples
nickrtorres
committed
3a29aed
View commit details
Copy full SHA for 3a29aed
Browse repository at this point
result_map_or_into_option: destructure lint tuple or return early
nickrtorres
committed
d0738bd
View commit details
Copy full SHA for d0738bd
Browse repository at this point
result_map_or_into_option: add `opt.map_or(None, |_| Some(y))` test
nickrtorres
committed
fb276dc
View commit details
Copy full SHA for fb276dc
Browse repository at this point
result_map_or_into_option: move arg checks into tuple assignment
nickrtorres
committed
acc3bc1
View commit details
Copy full SHA for acc3bc1
Browse repository at this point
result_map_or_into_option: fix `cargo dev fmt --check` errors
nickrtorres
committed
2533f56
View commit details
Copy full SHA for 2533f56
Browse repository at this point
CONTRIBUTING.md: fix broken triage link
nickrtorres
committed
fecdb72
View commit details
Copy full SHA for fecdb72
Browse repository at this point
result_map_or_into: fix dogfood_clippy error => {h,l}int
nickrtorres
committed
325d0b6
View commit details
Copy full SHA for 325d0b6
Browse repository at this point
Commits on Apr 5, 2020
result_map_or_into_option: fix syntax error in example
nickrtorres
committed
5d54fbb
View commit details
Copy full SHA for 5d54fbb
Browse repository at this point
Include OpAssign in suspicious_op_assign_impl
jpospychala
committed
9c9af1d
View commit details
Copy full SHA for 9c9af1d
Browse repository at this point
Commits on Apr 6, 2020
Make epsilon note spanless when comparing arrays
marcin-serwin
committed
f8fd4ac
View commit details
Copy full SHA for f8fd4ac
Browse repository at this point
Indicate when arrays are compared in error message
marcin-serwin
committed
7294acb
View commit details
Copy full SHA for 7294acb
Browse repository at this point
Split check_fn function
marcin-serwin
committed
16b4003
View commit details
Copy full SHA for 16b4003
Browse repository at this point
Make the epsilon note spanless
marcin-serwin
committed
4348af2
View commit details
Copy full SHA for 4348af2
Browse repository at this point
Lint on opt.as_ref().map(|x| &**x).
xiongmao86
committed
4f14826
View commit details
Copy full SHA for 4f14826
Browse repository at this point
Commits on Apr 7, 2020
Refine lint message.
xiongmao86
committed
d7056f8
View commit details
Copy full SHA for d7056f8
Browse repository at this point
Rollup merge of #5345 - Toxyxer:add-lint-for-float-in-array-comparison, r=flip1995
Show description for acd4342
flip1995
authored
acd4342
View commit details
Copy full SHA for acd4342
Browse repository at this point
Rollup merge of #5406 - flip1995:update_lints_fix, r=flip1995
Show description for 3da43d0
flip1995
authored
3da43d0
View commit details
Copy full SHA for 3da43d0
Browse repository at this point
Rollup merge of #5409 - dtolnay:letunit, r=flip1995
Show description for 52ca269
flip1995
authored
52ca269
View commit details
Copy full SHA for 52ca269
Browse repository at this point
Rollup merge of #5410 - dtolnay:trivially, r=flip1995
Show description for e26c922
flip1995
authored
e26c922
View commit details
Copy full SHA for e26c922
Browse repository at this point
Rollup merge of #5412 - dtolnay:tostring, r=flip1995
Show description for 5afb882
flip1995
authored
5afb882
View commit details
Copy full SHA for 5afb882
Browse repository at this point
Rollup merge of #5415 - nickrtorres:master, r=flip1995
Show description for 0c63766
flip1995
authored
0c63766
View commit details
Copy full SHA for 0c63766
Browse repository at this point
Rollup merge of #5417 - flip1995:doc_update, r=flip1995
Show description for 858bfd4
flip1995
authored
858bfd4
View commit details
Copy full SHA for 858bfd4
Browse repository at this point
Rollup merge of #5419 - dtolnay:unreadable, r=flip1995
Show description for 642d743
flip1995
authored
642d743
View commit details
Copy full SHA for 642d743
Browse repository at this point
Rollup merge of #5420 - dtolnay:newret, r=flip1995
Show description for 3ef6b9b
flip1995
authored
3ef6b9b
View commit details
Copy full SHA for 3ef6b9b
Browse repository at this point
Rollup merge of #5422 - nickrtorres:contributing-triage, r=flip1995
Show description for e55ec76
flip1995
authored
e55ec76
View commit details
Copy full SHA for e55ec76
Browse repository at this point
Rollup merge of #5424 - jpospychala:suspicious_op_assign_impl, r=flip1995
Show description for 1242808
flip1995
authored
1242808
View commit details
Copy full SHA for 1242808
Browse repository at this point
Rollup merge of #5425 - xiongmao86:issue5367, r=flip1995
Show description for 635518f
flip1995
authored
635518f
View commit details
Copy full SHA for 635518f
Browse repository at this point
Run fmt
flip1995
committed
f663da1
View commit details
Copy full SHA for f663da1
Browse repository at this point
You can’t perform that action at this time.