Skip to content

Audit usage of command_output methods in rmake.rs tests #125617

Description

@jieyouxu

They are typically not the semantics that's desired, i.e. they only provide the command output but does not assert that the command status is success. We should make sure we're not silently letting failed commands through.

Do we even want to allow command_output methods? It's likely less footgunny if we only provided CommandWrapper::{run, run_fail, run_fail_assert_exit_code} methods which perform asserts on the command exit status.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions