Skip to content

./x test --skip is sensitive to path separators on Windows #134198

Description

@ChrisDenton

Currently the following will not skip any tests on Windows even though the test path exists

./x test ui --skip tests/ui/traits/fn-pointer/bare-fn-no-impl-fn-ptr-99875.rs

This is because of using / instead of \ for the path separators. Ideally bootstrap should handle this.

Additionally it would be nice if --skip errored (or at least warned) if the given path didn't match anything.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-enhancementCategory: An issue proposing an enhancement or a PR with one.O-windowsOperating system: WindowsT-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions