Tracking issue for adding a lifetime specifier to macro_rules! #34303

Activity

1. sgrif commented on Jun 16, 2016

   

   sgrif

   on Jun 16, 2016

   Contributor

   More actions

   I'll open a new PR soon, I want to do one more thing on top of #33135

   👍React with 👍3Reacted by mitchmindtree, Stanko Krtalić and jjpe
2. apasel422

   added

   B-RFC-approvedBlocker: Approved by a merged RFC but not yet implemented.Blocker: Approved by a merged RFC but not yet implemented.

   on Jun 17, 2016
3. Phlosioneer commented on Jun 21, 2016

   

   Phlosioneer

   on Jun 21, 2016

   Contributor

   More actions

   Godspeed, @sgrif! This being in nightly would make my week.
4. comex commented on Jan 3, 2017

   

   comex

   on Jan 3, 2017

   Contributor

   More actions

   @sgrif Any update?
5. brson

   added

   B-unstableBlocker: Implemented in the nightly compiler and unstable.Blocker: Implemented in the nightly compiler and unstable.

   E-help-wantedCall for participation: Help is requested to fix this issue.Call for participation: Help is requested to fix this issue.

   on Mar 1, 2017
6. brson commented on Mar 1, 2017

   

   brson

   on Mar 1, 2017

   Contributor

   More actions

   This doesn't seem particularly hard. Help wanted.
7. durka commented on Mar 1, 2017

   

   durka

   on Mar 1, 2017

   Contributor

   More actions

   I wish we knew what the "one more thing" was besides just reopening the closed PR.
8. mikeyhew commented on May 4, 2017

   

   mikeyhew

   on May 4, 2017

   Contributor

   More actions

   I'd like to help implement this. Where do I start?
9. petrochenkov commented on May 4, 2017

   

   petrochenkov

   on May 4, 2017

   Contributor

   More actions

   @mikeyhew
   This is a good issue to start working on the compiler frontend.
   You may want to start with taking @sgrif's patch and rebasing it on the current master, and then making sure the tests pass.
   Then you'll have to add a feature gate for lifetime matcher and some docs (unstable book section) (see e0cd766, and 1d46805, and #41012 as a whole for examples of the same things being done with vis matcher.)

   @durka

   I wish we knew what the "one more thing" was besides just reopening the closed PR.

   This should be something truly marvelous, that this GitHub comment was too narrow to contain.

   😄React with 😄3Reacted by Niko Matsakis, ~ and ilyazub
10. Mark-Simulacrum

    added

    C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCCategory: An issue tracking the progress of sth. like the implementation of an RFC

    on Jul 22, 2017
11. bors

    added a commit that references this issue on Jan 1, 2018

    Auto merge of #46895 - ricochet1k:macro-lifetimes, r=jseyfried

    ...

    This issue will close once commit 1bcc6dc is merged into the 'main' branch.

    1bcc6dc
12. bors

    closed this as completedin #46895on Jan 1, 2018
13. sgrif commented on Jan 1, 2018

    

    sgrif

    on Jan 1, 2018

    Contributor

    More actions

    This issue should remain open until the feature is stable, right?
14. petrochenkov

    reopened this on Jan 1, 2018
15. 11 remaining items

    Load more

16. nikomatsakis commented on Mar 16, 2018

    

    nikomatsakis

    on Mar 16, 2018

    ContributorAuthor

    More actions

    @durka right, that's precisely what I was thinking when I wrote the "on the other hand" part. I think I'm going to resolve my concern -- otherwise I guess we need a bunch more matchers.

    @rfcbot resolve underscore-lifetime
17. durka commented on Mar 19, 2018

    

    durka

    on Mar 19, 2018

    Last edited by durka

    Contributor

    More actions

    @nikomatsakis please say "resolved" for the bot
18. nikomatsakis commented on Mar 20, 2018

    

    nikomatsakis

    on Mar 20, 2018

    ContributorAuthor

    More actions

    @rfcbot resolved underscore-lifetime

    Sigh.

    😄React with 😄2Reacted by kennytm and Daniel Ly
19. rfcbot

    added

    final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.In the final comment period and will be merged soon unless new substantive objections are raised.

    and removed

    proposed-final-comment-periodProposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.

    on Mar 20, 2018
20. rfcbot commented on Mar 20, 2018

    

    rfcbot

    on Mar 20, 2018

    More actions

    🔔 This is now entering its final comment period, as per the review above. 🔔
21. rfcbot commented on Mar 30, 2018

    

    rfcbot

    on Mar 30, 2018

    More actions

    The final comment period is now complete.
22. durka commented on Mar 30, 2018

    

    durka

    on Mar 30, 2018

    Contributor

    More actions

    🚀 🚀 🚀 🚀 🚀
23. bors

    added a commit that references this issue on May 14, 2018

    Auto merge of #50385 - durka:stabilize-macro-lifetime, r=petrochenkov

    ...

    cb1ce7d
24. Centril

    added

    disposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.This issue / PR is in PFCP or FCP with a disposition to merge it.

    finished-final-comment-periodThe final comment period is finished for this PR / Issue.The final comment period is finished for this PR / Issue.

    and removed

    final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.In the final comment period and will be merged soon unless new substantive objections are raised.

    on May 24, 2018
25. dtolnay commented on Jun 10, 2018

    

    dtolnay

    on Jun 10, 2018

    Member

    More actions

    We don't have tests for a macro_rules falling through to the next rule after a $:lifetime matcher.

    And it doesn't work. 😢 I filed #51477 to follow up.
26. Centril commented on Sep 15, 2018

    

    Centril

    on Sep 15, 2018

    Contributor

    More actions

    I think we can close this as it was stabilized; bugs and other things can be tracked as we usually do.
27. Centril

    closed this as completedon Sep 15, 2018