Repository navigation
rustdoc doesn't execute documentation tests for #[target_feature] functions #49723
Description
Example:
#![feature(target_feature)]
/// Foo
///
/// # Examples
///
/// ```
/// assert!(false);
/// ```
#[target_feature(enable="sse")]
pub unsafe fn foo() {}$ cargo test
Doc-tests foo
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
Activity
QuietMisdreavus commentedon Apr 6, 2018
I wonder if it has to do with #49225? I checked the sample with the nightlies that were made right before and after the change. The previous nightly finds the test, the next nightly does not:
QuietMisdreavus commentedon Apr 6, 2018
Oh wait, it's not that change, it's #48759 - it dynamically adds
doc(cfg)flags to the item, which rustdoc reads before executing the doctests.gnzlbg commentedon Apr 10, 2018
@QuietMisdreavus can we revert the part of #48759 that adds
doc(cfg)from#[target_feature]? It is not working properly and it is at least unclear to me what the default behavior for this should be at this point. Not doing anything about it allows people to do whatever they want. Figuring a good default and coming at a working implementation might be easier if we have a body of working doc tests that can be studied.QuietMisdreavus commentedon Apr 11, 2018
After some conversations on IRC, we discovered that rustdoc doesn't add target features to the configuration environment when extracting and running doctests. I've opened #49864 to fix this.
Rollup merge of rust-lang#49864 - QuietMisdreavus:doctest-target-feat…