Repository navigation
Suggestion for pub(crate) not always valid on multiple imports #50455
Description
Given code that looks like:
mod foo {
pub struct Bar;
pub struct Baz;
}
mod bar {
pub use foo::{Bar, Baz};
}you get:
Details
$ rustc +nightly src/lib.rs --crate-type lib -W rust_2018_idioms
warning: struct is never used: `Bar`
--> src/lib.rs:2:5
|
2 | pub struct Bar;
| ^^^^^^^^^^^^^^^
|
= note: #[warn(dead_code)] on by default
warning: struct is never used: `Baz`
--> src/lib.rs:3:5
|
3 | pub struct Baz;
| ^^^^^^^^^^^^^^^
warning: unreachable `pub` item
--> src/lib.rs:2:5
|
2 | pub struct Bar;
| ---^^^^^^^^^^^^
| |
| help: consider restricting its visibility: `pub(crate)`
|
= note: `-W unreachable-pub` implied by `-W rust-2018-idioms`
= help: or consider exporting it for use by other crates
warning: unreachable `pub` item
--> src/lib.rs:3:5
|
3 | pub struct Baz;
| ---^^^^^^^^^^^^
| |
| help: consider restricting its visibility: `pub(crate)`
|
= help: or consider exporting it for use by other crates
warning: unreachable `pub` item
--> src/lib.rs:7:19
|
7 | pub use foo::{Bar, Baz};
| ^^^ help: consider restricting its visibility: `pub(crate)`
|
= help: or consider exporting it for use by other crates
warning: unreachable `pub` item
--> src/lib.rs:7:24
|
7 | pub use foo::{Bar, Baz};
| ^^^ help: consider restricting its visibility: `pub(crate)`
|
= help: or consider exporting it for use by other crates
which when auto-fixed by cargo fix will produce:
mod foo {
pub(crate) struct Bar;
pub(crate) struct Baz;
}
mod bar {
pub use foo::{pub(crate), pub(crate)};
}which fails to compile!
cc @Manishearth
Activity
Manishearth commentedon May 4, 2018
cc @zackmdavis who implemented this
I also wish we had a better answer for this lint than chopping up spans, but the current architecture makes this hard (this has been a problem for clippy forever).
The problem here is that when we do HIR lowering we split apart
uses, and this totally breaks down.But we throw away the AST by the time we have access level info.
We can skip this lint for
pub usefor now, but that's not too great.I don't really have ideas for fixing this.
zackmdavis commentedon May 6, 2018
#50476 proposes not making suggestions for
useitems. (The lint itself still fires, of course.)We could add spans to
hir::Visibility?Rollup merge of rust-lang#50476 - zackmdavis:tame_unreachable_pub_sug…
Auto merge of #50476 - zackmdavis:tame_unreachable_pub_suggestion, r=…
Auto merge of #51866 - zackmdavis:hir_making_each_day_of_the_year, r=…