Repository navigation
spanned HIR node enums should be named FooKind rather than being named Foo_ and glob-exported #51968
Description
The convention enum
Something_ { SomethingVariant }is "deprecated" and exists in HIR only because not all HIR structures were updated to the "modern" formenum SomethingKind { Variant }like it was done in AST.
New structures should not use it, so it'd be better to rename
Visibility_toVisibilityKind.
The referenced changes to AST were mostly in February 2016's #31487 (justification). The following HIR nodes are still using the underscore-suffix convention, and should probably be changed to the Kind style for consistency:
Activity
call it `hir::VisibilityKind` instead of `hir::Visibility_:*`
varkor commentedon Jul 1, 2018
Presumably this applies to
Expr_too?zackmdavis commentedon Jul 1, 2018
Ah, yes: I was searching for
Spanned, but the same rationale would apply toExpr_,Ty_, andForeignItem_.oli-obk commentedon Jul 2, 2018
Since any of these changes will break clippy I would be delighted if a PR doing them would also update clippy with the relevant changes. Not a blocker though!
Auto merge of #52264 - csmoe:kind, r=oli-obk