Rust incorrectly accepts unbalanced parentheses

Rust incorrectly accepts the following code (which is missing a )):

pub struct Value {
}

pub fn new() -> Result<Value, ()> {
    Ok(Value {
    } // Look ma, no `)`!
}

So far this seems to only happen if the code is inside a submodule. Shell script to reproduce:

#!/bin/bash

cargo new --lib this_should_not_build
mkdir this_should_not_build/src/foo

cat >> this_should_not_build/src/lib.rs <<-'EOF'
    pub mod foo;
EOF

cat > this_should_not_build/src/foo/mod.rs <<-'EOF'
    pub struct Value {
    }

    pub fn new() -> Result<Value, ()> {
        Ok(Value {
        }
    }
EOF

cd this_should_not_build
cargo build

My compiler version: rustc 1.34.0-nightly (0ea22717a 2019-03-02)

Likely introduced in #57944. I'll take a look at it tomorrow. It's likely me forgetting to call emit_unclosed_delims in some scope.

Thanks for reporting this and fixing, with tests! This can be a bit disconcerting if you dev on nightly, but target some stable (which will then fail to build): dekellum/body-image@dc78182b66

Add regression test for rust-lang#58886

Auto merge of #58903 - estebank:forgetful-delims, r=petrochenkov

Add regression test for rust-lang#58886

Fix a compiler error that for a time was accepted by rustc

Navigation Menu

Repository navigation

Rust incorrectly accepts unbalanced parentheses #58886

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Rust incorrectly accepts unbalanced parentheses #58886

Description

Activity

estebank commented on Mar 3, 2019

dekellum commented on Mar 5, 2019

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions