Skip to content

rls no longer builds after rust-lang/rust#66879 #66885

Description

@rust-highfive

Hello, this is your friendly neighborhood mergebot.
After merging PR #66879, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.

cc @RalfJung, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @RalfJung, the PR reviewer, and nominating for compiler team prioritization.

Activity

  1. added
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    on Nov 30, 2019
  2. mati865 commented on Dec 4, 2019

    @mati865
    Member

    I'm not sure but this is possibly blocked on fixing rustfmt: rust-lang/rustfmt#3903

  3. pnkfelix commented on Dec 5, 2019

    @pnkfelix
    Contributor

    triage: P-medium, removing nomination.

  4. tmandry commented on Dec 9, 2019

    @tmandry
    Member

    Ping, is anyone working on this?

    From rust-lang/rustfmt#3903 (comment):

    I do not think this is blocking the broken RLS as AFAIK RLS does not directly depend on rustc-ap-* crates.

  5. Xanewok commented on Dec 10, 2019

    @Xanewok
    Contributor

    Sorry for that, somehow I was sure I addressed this 😲 Just opened #67198

  6. tmandry commented on Dec 11, 2019

    @tmandry
    Member

    @Xanewok no worries, thanks for the quick response :)

  7. added a commit that references this issue on Dec 11, 2019
    a233302
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P-mediumMedium priorityT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions