Skip to content

Use function shims to make sure EII works on apple targets - #151733

Merged
rust-bors[bot] merged 4 commits into
rust-lang:mainfrom
jdonszelmann:eii-on-apple
Feb 19, 2026
Merged

Use function shims to make sure EII works on apple targets#151733
rust-bors[bot] merged 4 commits into
rust-lang:mainfrom
jdonszelmann:eii-on-apple

Conversation

@jdonszelmann

@jdonszelmann jdonszelmann commented Jan 27, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

View all comments

Use function shims to make sure EII works on apple targets (and generally accepts target-arch attributes)

Explainer: #146348 (comment)
Tracking issue: #125418

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 27, 2026
@jdonszelmann jdonszelmann mentioned this pull request Jan 27, 2026
Open
49 tasks
@jdonszelmann

jdonszelmann commented Jan 27, 2026

Copy link
Copy Markdown
Contributor Author

@bors try jobs=aarch64-apple

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Jan 27, 2026
@bors
Auto merge of #151733 - jdonszelmann:eii-on-apple, r=<try>
7d5270a 
Use function shims to make sure EII works on apple targets


try-job: aarch64-apple
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jdonszelmann

jdonszelmann commented Jan 27, 2026

Copy link
Copy Markdown
Contributor Author

ah that's the rebase's fault

@jdonszelmann

jdonszelmann commented Jan 27, 2026

Copy link
Copy Markdown
Contributor Author

try build can still be interesting if the other test succeeds, but idk if we'll fail too fast, lemme rebase

@jdonszelmann
jdonszelmann force-pushed the eii-on-apple branch 2 times, most recently from 14c4dda to 2fef4ab Compare January 27, 2026 12:17
@rustbot

This comment has been minimized.

Sign in to view
@jdonszelmann

jdonszelmann commented Jan 27, 2026

Copy link
Copy Markdown
Contributor Author

@bors try cancel

@jdonszelmann

jdonszelmann commented Jan 27, 2026

Copy link
Copy Markdown
Contributor Author

@bors try jobs=aarch64-apple

@rust-bors

rust-bors Bot commented Jan 27, 2026

Copy link
Copy Markdown
Contributor

Try build cancelled. Cancelled workflows:

rust-bors Bot pushed a commit that referenced this pull request Jan 27, 2026
@bors
Auto merge of #151733 - jdonszelmann:eii-on-apple, r=<try>
8a39723 
Use function shims to make sure EII works on apple targets


try-job: aarch64-apple
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2026
@rust-bors

rust-bors Bot commented Jan 27, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 8a39723 failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jdonszelmann

jdonszelmann commented Jan 27, 2026

Copy link
Copy Markdown
Contributor Author

right, things are named differently, maybe we just shouldn't print that

@jdonszelmann

jdonszelmann commented Jan 27, 2026

Copy link
Copy Markdown
Contributor Author

@bors try jobs=aarch64-apple

rust-bors Bot pushed a commit that referenced this pull request Jan 27, 2026
@bors
Auto merge of #151733 - jdonszelmann:eii-on-apple, r=<try>
4507d01 
Use function shims to make sure EII works on apple targets


try-job: aarch64-apple
@rust-bors

This comment has been minimized.

Sign in to view
@jdonszelmann

jdonszelmann commented Jan 27, 2026

Copy link
Copy Markdown
Contributor Author

doesn't need the envvars anymore now, but let's just run the try build

@jdonszelmann

jdonszelmann commented Jan 27, 2026

Copy link
Copy Markdown
Contributor Author

r? @bjorn3 (if you feel comfortable with this one?)

@matthiaskrgr matthiaskrgr mentioned this pull request Feb 10, 2026
Closed
@matthiaskrgr

matthiaskrgr commented Feb 11, 2026

Copy link
Copy Markdown
Member

@bors r-
#152454 (comment)

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 11, 2026
@rustbot

rustbot commented Feb 18, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@jdonszelmann

jdonszelmann commented Feb 18, 2026

Copy link
Copy Markdown
Contributor Author

@bors try jobs=aarch64-apple,test-various

rust-bors Bot pushed a commit that referenced this pull request Feb 18, 2026
@bors
Auto merge of #151733 - jdonszelmann:eii-on-apple, r=<try>
3ae07b9 
Use function shims to make sure EII works on apple targets


try-job: aarch64-apple
try-job: test-various
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors

rust-bors Bot commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 3ae07b9 failed: CI

@jdonszelmann

jdonszelmann commented Feb 18, 2026

Copy link
Copy Markdown
Contributor Author

timeout?

@bors try jobs=aarch64-apple,test-various

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Feb 18, 2026
@bors
Auto merge of #151733 - jdonszelmann:eii-on-apple, r=<try>
85019dc 
Use function shims to make sure EII works on apple targets


try-job: aarch64-apple
try-job: test-various
@rust-bors

rust-bors Bot commented Feb 19, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 85019dc (85019dc5f9a3aa4d02b81fb6c416eaa62a559b29, parent: c043085801b7a884054add21a94882216df5971c)

@jdonszelmann

jdonszelmann commented Feb 19, 2026

Copy link
Copy Markdown
Contributor Author

@bors r=oli-obk

@rust-bors

rust-bors Bot commented Feb 19, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 91064bf has been approved by oli-obk

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 19, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 19, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Feb 19, 2026
@bors
Auto merge of #152839 - JonathanBrouwer:rollup-iPaprtK, r=JonathanBro…
b6bed6f 
…uwer

Rollup of 9 pull requests

Successful merges:

 - #151733 (Use function shims to make sure EII works on apple targets)
 - #152558 (rustc_expand: improve diagnostics for non-repeatable metavars in repetition)
 - #152596 (Make all multipart suggestions verbose)
 - #152815 (Add CURRENT_RUSTC_VERSION support for Clippy)
 - #152733 (Port #[rustc_doc_primitive] to the new attribute parser)
 - #152817 (Update enzyme submodule to match upstream)
 - #152819 (explicitly show behavior of <_>::assoc_fn)
 - #152823 (fix stale comments left over from ed3711e)
 - #152824 (Enable "View all comments" link feature in `triagebot.toml`)
@rust-bors
rust-bors Bot merged commit 46126ac into rust-lang:main Feb 19, 2026
12 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Feb 19, 2026
rust-timer added a commit that referenced this pull request Feb 19, 2026
@rust-timer
Unrolled build for #151733
381b929 
Rollup merge of #151733 - jdonszelmann:eii-on-apple, r=oli-obk

Use function shims to make sure EII works on apple targets

Use function shims to make sure EII works on apple targets (and generally accepts target-arch attributes)

Explainer: #146348 (comment)
Tracking issue: #125418
@bjorn3 bjorn3 added the F-extern_item_impls `#![feature(extern_item_impls)]` label Jul 8, 2026
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
@bors
Auto merge of #152839 - JonathanBrouwer:rollup-iPaprtK, r=JonathanBro…
b8f6a7c 
…uwer

Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#151733 (Use function shims to make sure EII works on apple targets)
 - rust-lang/rust#152558 (rustc_expand: improve diagnostics for non-repeatable metavars in repetition)
 - rust-lang/rust#152596 (Make all multipart suggestions verbose)
 - rust-lang/rust#152815 (Add CURRENT_RUSTC_VERSION support for Clippy)
 - rust-lang/rust#152733 (Port #[rustc_doc_primitive] to the new attribute parser)
 - rust-lang/rust#152817 (Update enzyme submodule to match upstream)
 - rust-lang/rust#152819 (explicitly show behavior of <_>::assoc_fn)
 - rust-lang/rust#152823 (fix stale comments left over from ed3711e)
 - rust-lang/rust#152824 (Enable "View all comments" link feature in `triagebot.toml`)
@github-actions github-actions Bot mentioned this pull request Sep 14, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oli-obk oli-obk oli-obk approved these changes

Assignees

@oli-obk oli-obk

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. F-extern_item_impls `#![feature(extern_item_impls)]` O-apple Operating system: Apple / Darwin (macOS, iOS, tvOS, visionOS, watchOS) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

7 participants

@jdonszelmann @rust-log-analyzer @rustbot @matthiaskrgr @oli-obk @madsmtm @bjorn3