Skip to content

Rollup of 7 pull requests - #162284

Open
JonathanBrouwer wants to merge 95 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-xBLkMAP
Open

Rollup of 7 pull requests#162284
JonathanBrouwer wants to merge 95 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-xBLkMAP

Conversation

@JonathanBrouwer

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost

Create a similar rollup

jyn514 and others added 30 commits August 17, 2026 09:23
- Organize by "About" -> "Contributing" -> "Editing" -> "Maintaining"
  rather than mixing sections
- Deduplicate a few lines into the guide itself
- Recommend `mdbook serve` over `mdbook build`
- Document `mdbook` layout and link to the upstream docs
- Document sembr and that relative links must use `.md` extensions
- Add a section on testing the tools in `ci/`
Make README more complete and easier to follow
Dedup a bunch of information that's already on Forge
This updates the rust-version file to da51146.
That is not all it does
Installing cargo tools (`cargo install`) without locked dependencies exposes users to supply-chain attacks to all the dependencies of the tool (https://blog.rust-lang.org/2026/08/20/supply-chain-attack-on-arrayref/). Using `cargo install --locked` reduces this risk to a compromise of the tool itself, while using the locked and hashed version of the dependencies.

I went through all `rg "cargo install"` hits in the repository and added `--locked` to all but explanatory examples (such as cargo's docs on `cargo install` itself). I validated that those tools publish functioning `Cargo.lock`s with https://gist.github.com/konstin/bcb1169c1c1120c259dca64e777a64d0.
- remove discouraging "pretty simple" in a complex chapter
- mention that queries are demand-driven, not just memoized
- emphasize that "query system" is a term of art (c.f. "Improper Nouns":
  https://siderea.dreamwidth.org/1773806.html)
touch-ups to "query system" chapter
…ocked

Install cargo tools with locked dependencies
fix outdated docs about what RA config `x setup` generates
Add a central index of dev-guide reading club discussions
 add some more compiler internals videos
tshepang and others added 15 commits September 4, 2026 08:33
…alle

sanitizers: Implement support for the sanitize ignorelist

The sanitize ignorelist gives central controls over which functions, files, etc. should be ignored and not sanitized. It is a common file format for clang and explained here:
https://clang.llvm.org/docs/SanitizerSpecialCaseList.html. This change adds support for this list in Rust as well.

r? @rcvalle
c-variadic: use `emit_ptr_va_arg` for `va_arg` on `sparc`

I've built GCC for the target and validated pretty extensively that this works. Using our helper does generate worse code for `i64` unfortunately, I've reported that as llvm/llvm-project#214594. But, given that this is a tier-3 target etc. I don't think it makes sense to go out of our way to do better, we can just wait for LLVM to resolve that issue.
make -Ctarget-feature warnings more explicitly FCWs

In rust-lang/compiler-team#994 we agreed that

> We also change the warning emitted for unknown features in -Ctarget-feature to be explicitly a future-compat warning, and eventually we make unknown features in -Ctarget-feature a hard error.

This PR implements that.
I also created a new tracking issue specifically for this FCW as the old one has all sorts of discussion about us even figuring out the problem in the first place: rust-lang#162235.
…ray, r=mu001999

Generalize Decodable impl for arrays to all types

This is almost the only impl that is not symetric with its Encodable counterpart. I tried to find out why in the history but it looks like this impl predates most of the generic symetric ones that are in this file, so it looks like it's not intentional.

I bumped into this randomly by changing a Vec to an array in some Mir types. The error was pretty confusing and It took me a while to figure out so I think it's worth generalizing this for somebody else in the future,  even though it's technically not necessary at the moment.

~~We piggyback off of `SmallVec` impl to avoid adding a `Default` bound or `MaybeUninit` unsafe dance. This moves the assert from the begining to the end of the loop.~~ We use `array::from_fn`
…ethercote

Update internal docs & tests to use `!` rather than `Infallible` in relation to `Try`

- Update docs, internal comments and tests to use `!` rather than `Infallible` in `Try` situations.
- Add a custom `enum Uninhabited {}` to specific clippy tests where unintentional future divergence in handling `!` vs other uninhabited types may be a possible concern

Refs:
- Never is ~~meow~~ now rust-lang#155499
- Try: rust-lang#84277 & rust-lang/goals#654
…r=fee1-dead

Clean up the AST visitor

The AST visitor is macro-heavy and complicated. This PR simplifies some aspects of it. Details in individual commits.

r? @fee1-dead
rustc-dev-guide subtree update

Subtree update of `rustc-dev-guide` to rust-lang/rustc-dev-guide@a6da162.

Created using https://github.com/rust-lang/josh-sync.

r? @ghost
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label Sep 4, 2026
@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs A-rustc-dev-guide Area: rustc-dev-guide PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 4, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Member Author

@bors r+ p=5

@rust-bors

rust-bors Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

📌 Commit c97aa40 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2026
@rust-bors

rust-bors Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

⌛ Testing commit c97aa40 with merge b924f94...

rust-bors Bot pushed a commit that referenced this pull request Sep 4, 2026
…uwer

Rollup of 7 pull requests

Successful merges:

 - #157808 (sanitizers: Implement support for the sanitize ignorelist)
 - #160660 (c-variadic: use `emit_ptr_va_arg` for `va_arg` on `sparc`)
 - #162237 (make -Ctarget-feature warnings more explicitly FCWs)
 - #160111 (Generalize Decodable impl for arrays to all types)
 - #162174 (Update internal docs & tests to use `!` rather than `Infallible` in relation to `Try`)
 - #162226 (Clean up the AST visitor)
 - #162281 (rustc-dev-guide subtree update)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs A-rustc-dev-guide Area: rustc-dev-guide PG-exploit-mitigations Project group: Exploit mitigations rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.