Revert "bootstrap: Enable rustdoc mergeable CCI for std and internal docs #161716" - #162339
Conversation
|
|
This comment has been minimized.
This comment has been minimized.
|
Weird. I thought I diffed the generated docs locally and they were essentially the same. Maybe I didn't diff the JS files.. 🤔 Thanks. @bors r+ |
This comment has been minimized.
This comment has been minimized.
|
The conflicting change is probably #162318, which I believe was an unrelated bugfix for the changes being reverted. So if we go ahead with the revert, it should be fine to lose that change as long as (e.g.) |
|
I also tried running the notriddle@dbd6be9 test case on it, and it passes. |
72aea01 to
c84edb3
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
|
Rebased. Now the revert is effectively both:
I checked locally that |
|
@bors r=Kobzol |
…uwer Rollup of 4 pull requests Successful merges: - #162032 (remove more trivial regions in evaluate_added_goals_and_make_canonical_response) - #161607 (Add #[track_caller] to signed integer div/rem methods) - #162339 (Revert "bootstrap: Enable rustdoc mergeable CCI for std and internal docs #161716") - #162158 (Revise documentation of `NumBuffer` and `format_into()`.)
Rollup merge of #162339 - jieyouxu:revert-mergeable-cci, r=Kobzol Revert "bootstrap: Enable rustdoc mergeable CCI for std and internal docs #161716" cc #162334. It seems that #161716 still has some issues with combining cross-crate info? Let's revert for now and reland once we figure out why we are regressing the search results 🤔 It's not obvious to me. I built `rustc-docs` dist component locally, and at least locally with #161716 reverted I can find `rustc::ast::Attribute` "normally" from the search results. This reverts commit a69a632, reversing changes made to c33d8f3. This also reverts #162318, since #162318 fixes an regression introduced in #162334. r? @Kobzol (or notriddle/bootstrap/rustdoc) cc @notriddle
cc #162334.
It seems that #161716 still has some issues with combining cross-crate info? Let's revert for now and reland once we figure out why we are regressing the search results 🤔 It's not obvious to me.
I built
rustc-docsdist component locally, and at least locally with #161716 reverted I can findrustc::ast::Attribute"normally" from the search results.This reverts commit a69a632, reversing changes made to c33d8f3.
This also reverts #162318, since #162318 fixes an regression introduced in #162334.
r? @Kobzol (or notriddle/bootstrap/rustdoc)
cc @notriddle