Rollup of 5 pull requests by JonathanBrouwer · Pull Request #162445 · rust-lang/rust

JonathanBrouwer · 2026-09-07T19:28:01Z

Successful merges:

Replace links to github.com/rust-lang/rfcs with links to the Rust RFC Book #162436 (Replace links to github.com/rust-lang/rfcs with links to the Rust RFC Book)
codegen_llvm: use minimum/maximum intrinsics now that they got fixed #162438 (codegen_llvm: use minimum/maximum intrinsics now that they got fixed)
Remove fields from TypeKind: Array, Slice #161896 (Remove fields from TypeKind: Array, Slice)
Avoid wrong suggestions for never type coerce #162276 (Avoid wrong suggestions for never type coerce)
Raise a delayed bug when comparing incompatible constructors #162421 (Raise a delayed bug when comparing incompatible constructors)

…FC Book

Replace links to `github.com/rust-lang/rfcs` with links to the Rust RFC Book I noticed many error codes link to Rust RFCs via the [source GitHub `.md` files](https://github.com/rust-lang/rfcs/tree/master/text) instead of linking to the [RFC Book](https://rust-lang.github.io/rfcs/). This PR updates those links to point to the RFC book - I also updated any other links to RFCs in the repo (not including subtrees) while I was at it.

@nikic

codegen_llvm: use minimum/maximum intrinsics now that they got fixed r? @nikic

@oli-obk

…y-slice, r=oli-obk Remove fields from TypeKind: Array, Slice Tracking issue rust-lang#146922 Part of the [Refactoring to many methods](https://rust-lang.zulipchat.com/#narrow/channel/572285-goals.2Freflection/topic/Refactoring.20to.20many.20methods/with/592226560) reflection subgoal. See that for the full context. In short for various reasons we are moving from an enum `TypeKind` where the variants hold the types information to one that just tells you the type kind. Separate methods on `TypeId` provide a way to get to the data that used to be in the variant. r? @oli-obk

…-option-expect-suggestion, r=hanna-kruppe Avoid wrong suggestions for never type coerce Fixes rust-lang#162241

…rieril Raise a delayed bug when comparing incompatible constructors Fixes rust-lang#162394

JonathanBrouwer · 2026-09-07T19:28:08Z

@bors r+ p=5

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,test-x86_64-gnu-aux,test-x86_64-gnu-llvm-21-3,test-x86_64-msvc-1,test-aarch64-apple-1,test-aarch64-apple-2,test-x86_64-mingw-1,test-i686-msvc-1,test-i686-msvc-2,test-armhf-gnu

rust-bors · 2026-09-07T19:28:11Z

📌 Commit 2447739 has been approved by JonathanBrouwer

It is now in the queue for this repository.

Rollup of 5 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-gnu-llvm-21-3 try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc-1 try-job: test-i686-msvc-2 try-job: test-armhf-gnu

rust-bors · 2026-09-07T22:40:23Z

☀️ Try build successful (CI)
Build commit: 579585d (579585ddf413b6a139251effd5ce6949b09f7a84)
Base parent: f0bbd8d (f0bbd8dfa962017309286c7feeea8b2ef9a881b0)

rust-bors · 2026-09-08T00:44:17Z

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 2m 52s
Pushing 2e6e39f to main...

github-actions · 2026-09-08T00:47:33Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing cea272f (parent) -> 2e6e39f (this PR)

Test differences

Show 130 test diffs

Stage 1

[ui (polonius)] tests/ui/const-generics/gca/const-pattern-field-type-mismatch-162394.rs: [missing] -> pass (J0)
[ui (polonius)] tests/ui/mismatched_types/never-option-unwrap-suggestion-issue-162241.rs: [missing] -> pass (J0)
[ui (polonius)] tests/ui/suggestions/never-coercion-equality-suggestion.rs: [missing] -> pass (J0)
[ui (polonius)] tests/ui/suggestions/never-coercion-suggestion-candidates.rs: [missing] -> pass (J0)
[ui] tests/ui/const-generics/gca/const-pattern-field-type-mismatch-162394.rs: [missing] -> pass (J1)
[ui] tests/ui/mismatched_types/never-option-unwrap-suggestion-issue-162241.rs: [missing] -> pass (J1)
[ui] tests/ui/suggestions/never-coercion-equality-suggestion.rs: [missing] -> pass (J1)
[ui] tests/ui/suggestions/never-coercion-suggestion-candidates.rs: [missing] -> pass (J1)

Stage 2

[ui] tests/ui/const-generics/gca/const-pattern-field-type-mismatch-162394.rs: [missing] -> pass (J2)
[ui] tests/ui/mismatched_types/never-option-unwrap-suggestion-issue-162241.rs: [missing] -> pass (J2)
[ui] tests/ui/suggestions/never-coercion-equality-suggestion.rs: [missing] -> pass (J2)
[ui] tests/ui/suggestions/never-coercion-suggestion-candidates.rs: [missing] -> pass (J2)

Additionally, 118 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 2e6e39f684e1c6b0bbfe16593a23d901e61219ca --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

test-x86_64-gnu-stdlib-semver-check: 10m 57s -> 17m 52s (+63.2%)
test-x86_64-gnu-llvm-22-1: 49m 59s -> 1h 19m (+59.8%)
test-x86_64-gnu-nopt: 1h 39m -> 2h 28m (+49.1%)
test-x86_64-gnu-gcc-core-tests: 12m 15s -> 17m 14s (+40.7%)
dist-ohos-x86_64: 57m 28s -> 1h 20m (+39.5%)
dist-arm-linux-musl: 1h 19m -> 1h 48m (+35.3%)
dist-x86_64-apple: 2h 50m -> 1h 54m (-33.0%)
test-x86_64-mingw-1: 3h 5m -> 2h 8m (-31.0%)
dist-x86_64-msvc-alt: 2h 47m -> 1h 58m (-29.2%)
test-various: 1h 37m -> 2h 5m (+28.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-09-08T01:29:22Z

Finished benchmarking commit (2e6e39f): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.8%	[1.4%, 2.3%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.5%	[-0.5%, -0.5%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.1%	[-0.5%, 2.3%]	3

Cycles

Results (primary 0.5%, secondary -5.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.1%	[0.6%, 2.7%]	6
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.7%	[-0.9%, -0.5%]	3
Improvements ✅ (secondary)	-5.1%	[-5.1%, -5.1%]	1
All ❌✅ (primary)	0.5%	[-0.9%, 2.7%]	9

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 477.826s -> 482.327s (0.94%)
Artifact size: 403.60 MiB -> 403.54 MiB (-0.02%)

rust-bors · 2026-09-08T01:49:00Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#162436	Replace links to `github.com/rust-lang/rfcs` with links to …	`60c1511243f6c0f9b26c247aab404e745e5b3705` (link)
#162438	codegen_llvm: use minimum/maximum intrinsics now that they …	`eab367ca907cea9a4c974c99a7f199ad62c53174` (link)
#161896	Remove fields from TypeKind: Array, Slice	`7807de01437da1d11999127ae6c6b46695dd1c3f` (link)
#162276	Avoid wrong suggestions for never type coerce	`a72f321b6df57def494ba7328e58189ea1e16117` (link)
#162421	Raise a delayed bug when comparing incompatible constructors	`1de021f0287e73cd8a18db0b84594c60e5e76f45` (link)

parent commit: cea272fa35

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

chenyukang and others added 12 commits September 6, 2026 22:19

Add regression tests for suggestions involving never coercions

abc7cc7

Avoid misleading suggestions based on never-to-any coercions

d1af9ce

Emit delayed bug when comparing incompatible constructors

196db98

Replace links to github.com/rust-lang/rfcs with links to the Rust R…

ac599d4

…FC Book

codegen_llvm: use minimum/maximum intrinsics now that they got fixed

e30341f

reflection: replace TypeKind::Slice's field with TypeId::element_ty

2edd314

reflection: replace TypeKind::Array field with methods

ed8f8b6

Rollup merge of rust-lang#162438 - RalfJung:llvm-minmax, r=nikic

5a02fc4

codegen_llvm: use minimum/maximum intrinsics now that they got fixed r? @nikic

Rollup merge of rust-lang#162276 - chenyukang:yukang-fix-162241-never…

3d89dfd

…-option-expect-suggestion, r=hanna-kruppe Avoid wrong suggestions for never type coerce Fixes rust-lang#162241

Rollup merge of rust-lang#162421 - mu001999-contrib:fix-162394, r=Nad…

2447739

…rieril Raise a delayed bug when comparing incompatible constructors Fixes rust-lang#162394

rust-bors Bot added the rollup A PR which is a rollup label Sep 7, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 7, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 8, 2026

rust-bors Bot merged commit 2e6e39f into rust-lang:main Sep 8, 2026
15 checks passed

rustbot added this to the 1.100.0 milestone Sep 8, 2026

This was referenced Sep 8, 2026

move bug and span_bug macros to rustc_span #161873

Open

Add #[rustc_edition_redirect] #160227

Open

Make min/max and copysign intrinsics generic #162414

Open

Navigation Menu

Uh oh!

Uh oh!

Rollup of 5 pull requests - #162445

Rollup of 5 pull requests#162445
rust-bors[bot] merged 12 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-zU1JtUm

JonathanBrouwer commented Sep 7, 2026

Uh oh!

JonathanBrouwer commented Sep 7, 2026

Uh oh!

rust-bors Bot commented Sep 7, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Sep 7, 2026

Uh oh!

rust-bors Bot commented Sep 8, 2026

Uh oh!

Uh oh!

github-actions Bot commented Sep 8, 2026

Stage 1

Stage 2

Uh oh!

rust-timer commented Sep 8, 2026

Uh oh!

rust-bors Bot commented Sep 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Uh oh!

Conversation

JonathanBrouwer commented Sep 7, 2026

Uh oh!

JonathanBrouwer commented Sep 7, 2026

Uh oh!

rust-bors Bot commented Sep 7, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Sep 7, 2026

Uh oh!

rust-bors Bot commented Sep 8, 2026

Uh oh!

Uh oh!

github-actions Bot commented Sep 8, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Sep 8, 2026

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

rust-bors Bot commented Sep 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants