Rollup of 15 pull requests by Zalathar · Pull Request #163086 · rust-lang/rust

Zalathar · 2026-09-21T02:47:32Z

Successful merges:

When error from local macro, include macro def span #161051 (When error from local macro, include macro def span)
add case mapping fast paths for Latin-1 #162750 (add case mapping fast paths for Latin-1)
Do not continue past rustc_resolve when encountering duplicated items #162831 (Do not continue past rustc_resolve when encountering duplicated items)
rustdoc: account for nested parens and split text events in bare urls lint #162835 (rustdoc: account for nested parens and split text events in bare urls lint)
Report runtime range endpoints for runtime values #163044 (Report runtime range endpoints for runtime values)
Use x30 register name with LLVM 23+ #163062 (Use x30 register name with LLVM 23+)
When compiling without a specified --edition, emit a note #158102 (When compiling without a specified --edition, emit a note)
Windows: don't error if access_mode is set on OpenOptions #162984 (Windows: don't error if access_mode is set on OpenOptions)
Avoid unreachable integer underflow check in CStr::count_bytes() #163005 (Avoid unreachable integer underflow check in CStr::count_bytes())
Prepare for the introduction of forced keywords (k#) #163019 (Prepare for the introduction of forced keywords (k#))
Dir: fix fallback impl for remove_dir #163020 (Dir: fix fallback impl for remove_dir)
Use verbose suggestion for mut binding instead of &mut binding #163047 (Use verbose suggestion for mut binding instead of &mut binding)
Fix ArgAttributes mismatches in ABI UI tests for LoongArch64 and RiscV64 #163075 (Fix ArgAttributes mismatches in ABI UI tests for LoongArch64 and RiscV64)
enable f128 from u64/i64 test #163079 (enable f128 from u64/i64 test)
Remove TypeChecker::root_cx #163082 (Remove TypeChecker::root_cx)

Co-authored-by: malezjaa <poreba.kris@gmail.com>

``` error[E0308]: mismatched types --> $DIR/ref-pat-suggestions.rs:29:13 | LL | let &mut _a = 0; | ^^^^^^^ - this expression has type `{integer}` | | | expected integer, found `&mut _` | = note: expected type `{integer}` found mutable reference `&mut _` help: to declare a mutable variable use | LL - let &mut _a = 0; LL + let mut _a = 0; | ```

- mention `-Zmacro-backtrace` only for non-local macros - include span for local macro encompassing error

Use same wording as cargo does when `package.edition` is unspecified. Do not suggest `--edition=future` on stable.

It's only used for `self.root_cx.root_def_id()`, but `self.infcx.root_def_id` is also available.

Duplicated items cause lots of confusing knock down errors. This change side-steps some known ICEs, and reduces the verbosity of crates with duplicated types at the cost of not emitting every error that we could. Update tests that no longer crash: 120873 -> `tests/ui/resolve/multiple_definitions_attribute_merging.rs` (already existing) 123690 -> `tests/ui/resolve/duplicated-enum-variant.rs` 155482 -> `tests/ui/resolve/duplicated-item-in-const-generics.rs` Added two cases from the report that still ICE.

…hite When error from local macro, include macro def span - mention `-Zmacro-backtrace` only for non-local macros - include span for local macro encompassing error

@Amanieu

…anieu add case mapping fast paths for Latin-1 Result: Benchmark | Before (ns/iter) | After (ns/iter) | Improvement -- | -- | -- | -- bench_ascii_mix_to_lowercase | 122,779.62 | 62,625.20 | 48.99% bench_ascii_mix_to_uppercase | 140,644.43 | 62,216.00 | 55.76% bench_non_ascii_char_to_lowercase | 178,361.80 | 62,815.57 | 64.78% bench_non_ascii_char_to_uppercase | 215,988.75 | 62,073.67 | 71.26% bench_non_latin1_char_to_lowercase | 296,788.33 | 293,113.17 | - bench_non_latin1_char_to_uppercase | 348,730.00 | 347,126.50 | - bench_ascii_char_to_lowercase | 65,546.00 | 62,120.53 | - bench_ascii_char_to_uppercase | 65,532.87 | 62,126.94 | - r? @Amanieu

@petrochenkov

…chenkov Do not continue past `rustc_resolve` when encountering duplicated items Duplicated items cause *lots* of confusing knock down errors. This change side-steps some known ICEs, and reduces the verbosity of crates with duplicated items at the cost of not emitting every error that we could. Noticed just how problematic these can be while looking at rust-lang#160695, as `#[derive]`s are particularly prone to the kind of confusion these duplicates cause. Fix rust-lang#120873, fix rust-lang#123690. r? @petrochenkov

@lolbinarycat

…l, r=lolbinarycat rustdoc: account for nested parens and split text events in bare urls lint Improve the `rustdoc::bare_urls` lint handling of underscores and parenthesis. This re-does rust-lang#162381, but it has more test cases, and it handles nesting correctly. r? @lolbinarycat Fixes rust-lang#162345

…me-range-patterns, r=petrochenkov Report runtime range endpoints for runtime values Fixes rust-lang#131327

@folkertdev

…rkaround, r=folkertdev Use x30 register name with LLVM 23+ Closes rust-lang#148900 Thanks to llvm/llvm-project#167783, LLVM now recognizes the `x30`/`x29` register names. r? @folkertdev

Zalathar · 2026-09-21T02:47:48Z

Rollup of everything not in #163071.

@bors r+ rollup=never p=5

rust-bors · 2026-09-21T02:47:51Z

📌 Commit 693c0e8 has been approved by Zalathar

It is now in the queue for this repository.

Rollup of 15 pull requests Successful merges: - #161051 (When error from local macro, include macro def span) - #162750 (add case mapping fast paths for Latin-1) - #162831 (Do not continue past `rustc_resolve` when encountering duplicated items) - #162835 (rustdoc: account for nested parens and split text events in bare urls lint) - #163044 (Report runtime range endpoints for runtime values) - #163062 (Use x30 register name with LLVM 23+) - #158102 (When compiling without a specified `--edition`, emit a note) - #162984 (Windows: don't error if `access_mode` is set on `OpenOptions`) - #163005 (Avoid unreachable integer underflow check in `CStr::count_bytes()`) - #163019 (Prepare for the introduction of forced keywords (`k#`)) - #163020 (Dir: fix fallback impl for remove_dir) - #163047 (Use verbose suggestion for `mut binding` instead of `&mut binding`) - #163075 (Fix ArgAttributes mismatches in ABI UI tests for LoongArch64 and RiscV64) - #163079 (enable `f128` from `u64`/`i64` test) - #163082 (Remove `TypeChecker::root_cx`)

rust-log-analyzer · 2026-09-21T05:05:13Z

The job test-x86_64-gnu-aux failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

rust-bors · 2026-09-21T05:05:43Z

💔 Test for 1710120 failed: CI. Failed job:

auto - test-x86_64-gnu-aux (web logs, enhanced plaintext logs)

JonathanBrouwer · 2026-09-21T06:34:35Z

@bors try jobs=test-x86_64-gnu-aux

Rollup of 15 pull requests try-job: test-x86_64-gnu-aux

Zalathar · 2026-09-21T06:37:28Z

The test failure in cargo looks like it should be real, but so far I have no idea what could be causing it.

JonathanBrouwer · 2026-09-21T06:43:27Z

I have no idea either, but I've seen weird race conditions causing things like this before so I could believe it being spurious

rust-bors · 2026-09-21T07:17:12Z

💔 Test for d20acba failed: CI. Failed job:

try - test-x86_64-gnu-aux (web logs, enhanced plaintext logs)

rust-log-analyzer · 2026-09-21T07:17:14Z

The job test-x86_64-gnu-aux failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

rust-bors · 2026-09-21T08:15:30Z

PR #158102, which is a member of this rollup, was unapproved.

ywxt and others added 30 commits September 14, 2026 13:44

add case mapping fast paths for Latin-1

a451894

Account for split text events in bare urls lint

01da50f

Co-authored-by: malezjaa <poreba.kris@gmail.com>

Account for nested parens in bare urls lint

8e4f287

Account for the separator between host and path

459ba37

Account for URLs with accidental formatting

a83dd65

Avoid integer underflow in CStr::count_bytes()

ae2ecf5

Dir: fix fallback impl for remove_dir

bc5fd06

Add regression tests for runtime range pattern endpoints

ea2fa3e

Diagnose runtime range endpoints before reporting unsupported types

64695f1

When error from local macro, include macro def span

f1e9e5e

- mention `-Zmacro-backtrace` only for non-local macros - include span for local macro encompassing error

When compiling without a specified --edition, emit a note

5c0fee6

Use same wording as cargo does when `package.edition` is unspecified. Do not suggest `--edition=future` on stable.

Use eprintln!() instead of a note for unspecified --edition

2784d28

Use x30 register name with LLVM 23+

35ec478

Use r14 register name with LLVM 23+

3de0624

Fix ArgAttributes mismatches in ABI UI tests for LoongArch64 and RiscV64

81d8904

Test windows access_mode override

21d6920

Windows: don't error if access_mode is set

ac5ff45

Refactor access_mode case out of match

39f76c9

Replace IdentIsRaw with IdentKind

aceae2d

Introduce helper Token::non_raw_ident

3caa23d

enable f128 from u64/i64 test

ebf08b9

Remove TypeChecker::root_cx

93c8966

It's only used for `self.root_cx.root_def_id()`, but `self.infcx.root_def_id` is also available.

Rollup merge of rust-lang#161051 - estebank:macro_backtrace, r=adwinw…

cd49aa2

…hite When error from local macro, include macro def span - mention `-Zmacro-backtrace` only for non-local macros - include span for local macro encompassing error

Rollup merge of rust-lang#163044 - chenyukang:yukang-fix-131327-runti…

23d573c

…me-range-patterns, r=petrochenkov Report runtime range endpoints for runtime values Fixes rust-lang#131327

Rollup merge of rust-lang#163062 - malezjaa:remove-aarch64-x30-asm-wo…

7299135

…rkaround, r=folkertdev Use x30 register name with LLVM 23+ Closes rust-lang#148900 Thanks to llvm/llvm-project#167783, LLVM now recognizes the `x30`/`x29` register names. r? @folkertdev

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 21, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Sep 21, 2026

Auto merge of #163086 - Zalathar:rollup-w9maqUj, r=<try>

d20acba

Rollup of 15 pull requests try-job: test-x86_64-gnu-aux

Zalathar mentioned this pull request Sep 21, 2026

When compiling without a specified --edition, emit a note #158102

Open

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2026

JonathanBrouwer closed this Sep 21, 2026

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 21, 2026

rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 21, 2026

Navigation Menu

Uh oh!

Rollup of 15 pull requests - #163086

Rollup of 15 pull requests#163086
Zalathar wants to merge 39 commits into
rust-lang:mainfrom
Zalathar:rollup-w9maqUj

Zalathar commented Sep 21, 2026

Uh oh!

Zalathar commented Sep 21, 2026

Uh oh!

rust-bors Bot commented Sep 21, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Sep 21, 2026

Uh oh!

rust-bors Bot commented Sep 21, 2026

Uh oh!

JonathanBrouwer commented Sep 21, 2026

Uh oh!

This comment has been minimized.

Zalathar commented Sep 21, 2026

Uh oh!

JonathanBrouwer commented Sep 21, 2026 •

edited

Loading

Uh oh!

rust-bors Bot commented Sep 21, 2026

Uh oh!

rust-log-analyzer commented Sep 21, 2026

Uh oh!

rust-bors Bot commented Sep 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

Uh oh!

Conversation

Zalathar commented Sep 21, 2026

Uh oh!

Zalathar commented Sep 21, 2026

Uh oh!

rust-bors Bot commented Sep 21, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Sep 21, 2026

Uh oh!

rust-bors Bot commented Sep 21, 2026

Uh oh!

JonathanBrouwer commented Sep 21, 2026

Uh oh!

This comment has been minimized.

Zalathar commented Sep 21, 2026

Uh oh!

JonathanBrouwer commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-bors Bot commented Sep 21, 2026

Uh oh!

rust-log-analyzer commented Sep 21, 2026

Uh oh!

rust-bors Bot commented Sep 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

JonathanBrouwer commented Sep 21, 2026 •

edited

Loading