Skip to content

Rollup of 12 pull requests - #163208

Merged
rust-bors[bot] merged 28 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-324SB25
Sep 23, 2026
Merged

rust-bors[bot] merged 28 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-324SB25

Conversation

@JonathanBrouwer

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost

Create a similar rollup

malezjaa and others added 28 commits September 12, 2026 23:55
Keeping it up-to-date and resolving minor issues with it.
It's a field that can be used for sorting diagnostics. By default it is
set to the primary span. It's only used for `BorrowckDiagnosticsBuffer`.

This commit removes it and adds a `sort_span` to each diagnostic
recorded in `BorrowckDiagnosticsBuffer`. This avoids various other
pieces of code having to deal with it.
Both will be used by the amdgpu target to implement the `gpu-kernel`
ABI.

`address_space` specifies the address space of an indirect argument.

`AmdgpuKernelArg` translates to LLVM’s byref, which is similar to
on_stack/byval, however, there is no extra copy made, the pointer may
not point to the stack but can point to some other address space, and
the passed argument should not be modified.

byval and byref are mutually exclusive, so change on_stack to an enum
with the new states, Pointer (none), OnStack and AmdgpuKernelArg.
Add support to pass structs, arrays and vectors to amdgpu kernels.
Scalars and vectors are taken by value, aggregates are passed by byref
pointers. Structs containing a single scalar/vector are handled like
a scalar.

Judging from clang tests, nvptx seems to do somewhat the same, just
using byval instead of byref: https://github.com/llvm/llvm-project/blob/3a8affeef4da19d39191aac316e189eca3214a8c/clang/test/CodeGenCUDA/kernel-args.cu

I tested a couple of the lit test signatures on real hardware and it
seems to work fine. Given the relatively simple implementation, I hope
this amount of testing is enough (the C calling convention seems like
a worse fit for Rust’s current ABI code, it’s still giving me headaches).
It's no longer ever used for stashing, so the code looking for it is
dead.

It became dead in PR 141610 when `generic_arg_infer` was stabilized and
`[T; _]` became valid.
Co-authored-by: Boxy <rust@boxyuwu.dev>
Properly implement the gpu-kernel ABI for amdgpu

Add support to pass structs, arrays and vectors to amdgpu kernels.
Scalars and vectors are taken by value, aggregates are passed by byref
pointers. Structs containing a single scalar/vector are handled like
a scalar.

Judging from clang tests, nvptx seems to do somewhat the same, just
using byval instead of byref: https://github.com/llvm/llvm-project/blob/e4e18dba3d77f4a3eea58bcc9ccae5a5498ede7c/clang/test/CodeGenCUDA/kernel-args.cu

I tested a couple of the lit test signatures on real hardware and it
seems to work fine. Given the relatively simple implementation, I hope
this amount of testing is enough (the C calling convention seems like
a worse fit for Rust’s current ABI code, it’s still giving me headaches).

This adds two members to `PassMode::Indirect`.

`address_space` specifies the address space of an on_stack/byval or
by_ref pointer argument.

`by_ref` translates to LLVM’s byref, which is similar to on_stack/byval,
however, there is no extra copy made, the pointer may not point to the
stack but can point to some other address space, and the passed argument
should not be modified.

Both are used by the amdgpu target to implement the `gpu-kernel`
ABI.

Tracking issue for the `gpu-kernel` ABI: rust-lang#135467
Tracking issue for the amdgpu target: rust-lang#135024
…Titor

std: Update `wasip3` crate dependency

Keeping it up-to-date and resolving minor issues with it.
Cleanup offload build steps

We used to generate a couple of artifacts only because clang offload tooling required them. Now that we fully control the build steps on the Rust side without clang tooling, we can remove most of them. I'll make a follow-up PR afterwards to also remove device.bin artifacts and pass the normal rustc outputs of the device compilation pass.

r? oli-obk
…ForArrayLengths, r=BoxyUwU

Remove unused `StashKey::UnderscoreForArrayLengths`

It's no longer ever used for stashing, so the code looking for it is dead.

It became dead in rust-lang#141610 when `generic_arg_infer` was stabilized and `[T; _]` became valid.

r? @BoxyUwU
rename direct_const_arg! to gca!

Also re-export it from `std`, and make most tests `use std::gca;` rather than writing out `core::` every time the macro is called.

Part of the design rework discussed in Zulip [#project-const-generics > talkies at last @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/260443-project-const-generics/topic/talkies.20at.20last/near/620368825)

r? @BoxyUwU
…nnethercote

Remove `suggestion_for_allocator_api`

It's dead code since rust-lang#156882

cc @nia-e
…, r=ShoyuVanilla

document `#[rustc_dyn_incompatible_trait]`
…strained-const-args, r=BoxyUwU

regression test for unconstrained const args

Closes rust-lang#146906
…re-suggestion, r=nnethercote

Enhance mutable closure suggestions with as_mut() support

This PR changed `can_use_as_ref` to support `as_mut` when `as_ref` is not proper.
Fix Typo in `std::sys::process::unix::unsupported::wait_status` Docs

Noticed while collecting data on conditional compilation for potential aliasing (see [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/219381-t-libs/topic/Using.20.60build.2Ers.60.20for.20cfg.20aliases.20in.20.60std.60/with/625458363) for details) that this attribute was missing its closing brace. Extremely trivial, might as well fix it!
…, r=lqd

Remove `DiagInner::sort_span`

It's a field that can be used for sorting diagnostics. By default it is set to the primary span. It's only used for `BorrowckDiagnosticsBuffer`.

This commit removes it and adds a `sort_span` to each diagnostic recorded in `BorrowckDiagnosticsBuffer`. This avoids various other pieces of code having to deal with it.

r? @lqd
…bit, r=tgross35

Fix flt2dec build on 16-bit targets

Closes rust-lang#163158.

Fixes build breakage  rust-lang#162879 on the two 16-bit targets, `avr-none` and `msp430-none-elf`, by including `target_pointer_width = "16"` in all the cfg attributes for the u32 implementations for bignum and flt2dec.
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label Sep 23, 2026
@rustbot rustbot added the A-attributes Area: Attributes (`#[…]`, `#![…]`) label Sep 23, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Member Author

@bors r+ p=5

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,test-x86_64-gnu-aux,test-x86_64-gnu-llvm-21-3,test-x86_64-msvc-1,test-aarch64-apple-1,test-aarch64-apple-2,test-x86_64-mingw-1,test-i686-msvc,test-armhf-gnu

@rust-bors

rust-bors Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 1ce8a26 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 23, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Sep 23, 2026
Rollup of 12 pull requests


try-job: dist-various-1
try-job: test-various
try-job: test-x86_64-gnu-aux
try-job: test-x86_64-gnu-llvm-21-3
try-job: test-x86_64-msvc-1
try-job: test-aarch64-apple-1
try-job: test-aarch64-apple-2
try-job: test-x86_64-mingw-1
try-job: test-i686-msvc
try-job: test-armhf-gnu
@rust-bors

This comment has been minimized.

@rust-bors

rust-bors Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 21081f0 (21081f0c835788a2285de742bc9bd5b79fdca16c)
Base parent: 52d0fd8 (52d0fd8771cf35f8fdb31a41a96d545cebb74931)

@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 23, 2026
@rust-bors

rust-bors Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 2h 56m 43s
Pushing a92214c to main...

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 9a9d194 (parent) -> a92214c (this PR)

Test differences

Show 98 test diffs

Stage 1

  • [ui (polonius)] tests/ui/attributes/doc_examples/rustc_dyn_incompatible_trait.rs: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/attributes/doc_examples/rustc_dyn_incompatible_trait2.rs: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/const-generics/gca/direct-const-arg-fn-call.rs: pass -> [missing] (J0)
  • [ui (polonius)] tests/ui/const-generics/gca/gca-macro-fn-call.rs: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/const-generics/mgca/bad-direct-const-arg.rs: pass -> [missing] (J0)
  • [ui (polonius)] tests/ui/const-generics/mgca/bad-gca-macro.rs: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/const-generics/mgca/direct-const-arg-correct-rib.rs: pass -> [missing] (J0)
  • [ui (polonius)] tests/ui/const-generics/mgca/direct-const-arg-feature-gate.rs: pass -> [missing] (J0)
  • [ui (polonius)] tests/ui/const-generics/mgca/direct-const-arg-multiple-exprs.rs: pass -> [missing] (J0)
  • [ui (polonius)] tests/ui/const-generics/mgca/direct_const_arg-infer-as-type.rs: pass -> [missing] (J0)
  • [ui (polonius)] tests/ui/const-generics/mgca/gca-macro-correct-rib.rs: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/const-generics/mgca/gca-macro-feature-gate.rs: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/const-generics/mgca/gca-macro-infer-as-type.rs: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/const-generics/mgca/gca-macro-multiple-exprs.rs: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/const-generics/mgca/invalid-direct-const-arg-owner-issue-159172.rs#expr: pass -> [missing] (J0)
  • [ui (polonius)] tests/ui/const-generics/mgca/invalid-direct-const-arg-owner-issue-159172.rs#ty: pass -> [missing] (J0)
  • [ui (polonius)] tests/ui/const-generics/mgca/invalid-gca-macro-owner-issue-159172.rs#expr: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/const-generics/mgca/invalid-gca-macro-owner-issue-159172.rs#ty: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/const-generics/mgca/multi_braced_direct_const_args.rs: pass -> [missing] (J0)
  • [ui (polonius)] tests/ui/const-generics/mgca/multi_braced_gca_macro.rs: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/const-generics/mgca/unconstrained-type-params.rs: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/suggestions/as-mut-closure.rs: [missing] -> pass (J0)
  • [ui] tests/ui/attributes/doc_examples/rustc_dyn_incompatible_trait.rs: [missing] -> pass (J1)
  • [ui] tests/ui/attributes/doc_examples/rustc_dyn_incompatible_trait2.rs: [missing] -> pass (J1)
  • [ui] tests/ui/const-generics/gca/direct-const-arg-fn-call.rs: pass -> [missing] (J1)
  • [ui] tests/ui/const-generics/gca/gca-macro-fn-call.rs: [missing] -> pass (J1)
  • [ui] tests/ui/const-generics/mgca/bad-direct-const-arg.rs: pass -> [missing] (J1)
  • [ui] tests/ui/const-generics/mgca/bad-gca-macro.rs: [missing] -> pass (J1)
  • [ui] tests/ui/const-generics/mgca/direct-const-arg-correct-rib.rs: pass -> [missing] (J1)
  • [ui] tests/ui/const-generics/mgca/direct-const-arg-feature-gate.rs: pass -> [missing] (J1)
  • [ui] tests/ui/const-generics/mgca/direct-const-arg-multiple-exprs.rs: pass -> [missing] (J1)
  • [ui] tests/ui/const-generics/mgca/direct_const_arg-infer-as-type.rs: pass -> [missing] (J1)
  • [ui] tests/ui/const-generics/mgca/gca-macro-correct-rib.rs: [missing] -> pass (J1)
  • [ui] tests/ui/const-generics/mgca/gca-macro-feature-gate.rs: [missing] -> pass (J1)
  • [ui] tests/ui/const-generics/mgca/gca-macro-infer-as-type.rs: [missing] -> pass (J1)
  • [ui] tests/ui/const-generics/mgca/gca-macro-multiple-exprs.rs: [missing] -> pass (J1)
  • [ui] tests/ui/const-generics/mgca/invalid-direct-const-arg-owner-issue-159172.rs#expr: pass -> [missing] (J1)
  • [ui] tests/ui/const-generics/mgca/invalid-direct-const-arg-owner-issue-159172.rs#ty: pass -> [missing] (J1)
  • [ui] tests/ui/const-generics/mgca/invalid-gca-macro-owner-issue-159172.rs#expr: [missing] -> pass (J1)
  • [ui] tests/ui/const-generics/mgca/invalid-gca-macro-owner-issue-159172.rs#ty: [missing] -> pass (J1)
  • [ui] tests/ui/const-generics/mgca/multi_braced_direct_const_args.rs: pass -> [missing] (J1)
  • [ui] tests/ui/const-generics/mgca/multi_braced_gca_macro.rs: [missing] -> pass (J1)
  • [ui] tests/ui/const-generics/mgca/unconstrained-type-params.rs: [missing] -> pass (J1)
  • [ui] tests/ui/suggestions/as-mut-closure.rs: [missing] -> pass (J1)
  • [pretty] tests/pretty/direct-const-arg.rs: pass -> [missing] (J5)
  • [pretty] tests/pretty/gca-macro.rs: [missing] -> pass (J5)
  • [codegen] tests/codegen-llvm/amdgpu-abi/struct-abi.rs: [missing] -> pass (J6)

Stage 2

  • [ui] tests/ui/attributes/doc_examples/rustc_dyn_incompatible_trait.rs: [missing] -> pass (J2)
  • [ui] tests/ui/attributes/doc_examples/rustc_dyn_incompatible_trait2.rs: [missing] -> pass (J2)
  • [ui] tests/ui/const-generics/gca/direct-const-arg-fn-call.rs: pass -> [missing] (J2)
  • [ui] tests/ui/const-generics/gca/gca-macro-fn-call.rs: [missing] -> pass (J2)
  • [ui] tests/ui/const-generics/mgca/bad-direct-const-arg.rs: pass -> [missing] (J2)
  • [ui] tests/ui/const-generics/mgca/bad-gca-macro.rs: [missing] -> pass (J2)
  • [ui] tests/ui/const-generics/mgca/direct-const-arg-correct-rib.rs: pass -> [missing] (J2)
  • [ui] tests/ui/const-generics/mgca/direct-const-arg-feature-gate.rs: pass -> [missing] (J2)
  • [ui] tests/ui/const-generics/mgca/direct-const-arg-multiple-exprs.rs: pass -> [missing] (J2)
  • [ui] tests/ui/const-generics/mgca/direct_const_arg-infer-as-type.rs: pass -> [missing] (J2)
  • [ui] tests/ui/const-generics/mgca/gca-macro-correct-rib.rs: [missing] -> pass (J2)
  • [ui] tests/ui/const-generics/mgca/gca-macro-feature-gate.rs: [missing] -> pass (J2)
  • [ui] tests/ui/const-generics/mgca/gca-macro-infer-as-type.rs: [missing] -> pass (J2)
  • [ui] tests/ui/const-generics/mgca/gca-macro-multiple-exprs.rs: [missing] -> pass (J2)
  • [ui] tests/ui/const-generics/mgca/invalid-direct-const-arg-owner-issue-159172.rs#expr: pass -> [missing] (J2)
  • [ui] tests/ui/const-generics/mgca/invalid-direct-const-arg-owner-issue-159172.rs#ty: pass -> [missing] (J2)
  • [ui] tests/ui/const-generics/mgca/invalid-gca-macro-owner-issue-159172.rs#expr: [missing] -> pass (J2)
  • [ui] tests/ui/const-generics/mgca/invalid-gca-macro-owner-issue-159172.rs#ty: [missing] -> pass (J2)
  • [ui] tests/ui/const-generics/mgca/multi_braced_direct_const_args.rs: pass -> [missing] (J2)
  • [ui] tests/ui/const-generics/mgca/multi_braced_gca_macro.rs: [missing] -> pass (J2)
  • [ui] tests/ui/const-generics/mgca/unconstrained-type-params.rs: [missing] -> pass (J2)
  • [ui] tests/ui/suggestions/as-mut-closure.rs: [missing] -> pass (J2)
  • [pretty] tests/pretty/direct-const-arg.rs: pass -> [missing] (J3)
  • [pretty] tests/pretty/gca-macro.rs: [missing] -> pass (J3)
  • [codegen] tests/codegen-llvm/amdgpu-abi/struct-abi.rs: [missing] -> pass (J4)

Additionally, 26 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard a92214c92df8cc0261f5ab5c08c6376c2c03a958 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-loongarch64-musl: 1h 15m -> 2h 4m (+64.1%)
  2. test-x86_64-rust-for-linux: 37m 57s -> 59m 52s (+57.8%)
  3. test-x86_64-gnu-gcc-core-tests: 11m 58s -> 18m 49s (+57.2%)
  4. test-x86_64-gnu-llvm-22-2: 1h 8m -> 1h 44m (+51.7%)
  5. test-x86_64-gnu-llvm-21-2: 1h 7m -> 1h 40m (+48.6%)
  6. test-x86_64-gnu-miri: 1h 2m -> 1h 29m (+42.8%)
  7. test-x86_64-gnu-stdlib-semver-check: 11m 50s -> 16m 40s (+40.8%)
  8. test-x86_64-gnu-llvm-21-3: 1h 49m -> 1h 14m (-32.0%)
  9. test-armhf-gnu: 1h 11m -> 1h 33m (+31.6%)
  10. test-i686-gnu-1: 2h 14m -> 1h 35m (-28.5%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (a92214c): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.8% [0.7%, 1.0%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary 0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.9% [0.9%, 0.9%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

Results (secondary -1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.1% [3.2%, 5.2%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-6.5% [-9.7%, -4.4%] 3
All ❌✅ (primary) - - 0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 489.957s -> 501.272s (2.31%)
Artifact size: 407.04 MiB -> 406.37 MiB (-0.17%)

@rust-bors

rust-bors Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#162177 Properly implement the gpu-kernel ABI for amdgpu 2eefc8766c41447108a2ce74176ccea7b5ec4d97
(link)
#163168 std: Update wasip3 crate dependency 8421ad326f4b40ef7630fb0bdf7155dcc1f4e648
(link)
#163179 Cleanup offload build steps 789b017c444b66899ac1615adacc4cdf43658f06
(link)
#163194 Remove unused StashKey::UnderscoreForArrayLengths da2f7e20c1f680d151b263bdea0ed0ed0d2d2f4d
(link)
#163198 rename direct_const_arg! to gca! c5e08135ec2de997bef2f21bb4817810a79ebffe
(link)
#163205 Remove suggestion_for_allocator_api cad1e1b562c033cb7aaf7fd6b62d63f6cdc28e67
(link)
#162497 document #[rustc_dyn_incompatible_trait] 9cfd87e5358a97aafe83dac4a3770bc931432cf7
(link)
#162702 regression test for unconstrained const args 9fba0a8dce285161964e196145f78691503f5073
(link)
#163191 Enhance mutable closure suggestions with as_mut() support 2901913f370033b6c388a1958106e7c2f192fa08
(link)
#163192 Fix Typo in `std::sys::process::unix::unsupported::wait_sta… 4fe9beb38817a5a83a75440fc95ad7f1610f2da6
(link)
#163196 Remove DiagInner::sort_span bfe5389d868531672805d90bc131459cdcce9c51
(link)
#163197 Fix flt2dec build on 16-bit targets f447349939202c1e7c947ee62465133ecaf36a14
(link)

parent commit: 9a9d1946d1

In the case of a perf regression, run the following command with the SHAs of each PR you suspect might be the cause: @rust-timer triage $SHA $SHA $SHA..., or run @rust-timer triage all to benchmark all rollup members.

@JonathanBrouwer

Copy link
Copy Markdown
Member Author

@rust-timer triage all

@rust-timer

rust-timer commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator
Running triage with 1 benchmark

Triage only executes the benchmarks on rollup members, that were changed significantly on the rollup.
For this rollup, these benchmarks are:

  • coercions

#162177 2eefc87 Properly implement the gpu-kernel ABI for amdgpu

This perf run didn't have relevant results for the `instruction count` metric.

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.


#163168 8421ad3 std: Update wasip3 crate dependency

This perf run didn't have relevant results for the `instruction count` metric.

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.


#163179 789b017 Cleanup offload build steps

This perf run didn't have relevant results for the `instruction count` metric.

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.


#163194 da2f7e2 Remove unused StashKey::UnderscoreForArrayLengths

This perf run didn't have relevant results for the `instruction count` metric.

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary -1.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.4% [-1.4%, -1.4%] 1
All ❌✅ (primary) - - 0

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.


#163198 c5e0813 rename direct_const_arg! to gca!

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.8% [0.7%, 0.9%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.


#163205 cad1e1b Remove suggestion_for_allocator_api

This perf run didn't have relevant results for the `instruction count` metric.

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary -2.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.6% [-2.6%, -2.6%] 1
All ❌✅ (primary) - - 0

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.


#162497 9cfd87e document #[rustc_dyn_incompatible_trait]

This perf run didn't have relevant results for the `instruction count` metric.

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary -4.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-4.3% [-4.3%, -4.3%] 1
All ❌✅ (primary) - - 0

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.


#162702 9fba0a8 regression test for unconstrained const args

This perf run didn't have relevant results for the `instruction count` metric.

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.


#163191 2901913 Enhance mutable closure suggestions with as_mut() support

This perf run didn't have relevant results for the `instruction count` metric.

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.


#163192 4fe9beb Fix Typo in std::sys::process::unix::unsupported::wait_status Docs

This perf run didn't have relevant results for the `instruction count` metric.

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.


#163196 bfe5389 Remove DiagInner::sort_span

This perf run didn't have relevant results for the `instruction count` metric.

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary -1.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.5% [-1.5%, -1.5%] 1
All ❌✅ (primary) - - 0

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.


#163197 f447349 Fix flt2dec build on 16-bit targets

This perf run didn't have relevant results for the `instruction count` metric.

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. T-rustfmt Relevant to the rustfmt team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.