Skip to content

Drop WC_ERR_INVALID_CHARS from Windows stdio #164175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rust-bors merged 1 commit into from
Oct 16, 2026
Merged

Drop WC_ERR_INVALID_CHARS from Windows stdio #164175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 12 additions & 18 deletions library/std/src/io/stdio.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,9 +594,8 @@ impl fmt::Debug for StdinLock<'_> {
///
/// ### Note: Windows Portability Considerations
///
/// When operating in a console, the Windows implementation of this stream does not support
/// non-UTF-8 byte sequences. Attempting to write bytes that are not valid UTF-8 will return
/// an error.
/// When operating in a console, the Windows implementation of this stream decodes bytes
/// as UTF-8, replacing malformed sequences with the Unicode replacement character (U+FFFD).
///
/// In a process with a detached console, such as one using
/// `#![windows_subsystem = "windows"]`, or in a child process spawned from such a process,
Expand Down Expand Up @@ -627,9 +626,8 @@ pub struct Stdout {
///
/// ### Note: Windows Portability Considerations
///
/// When operating in a console, the Windows implementation of this stream does not support
/// non-UTF-8 byte sequences. Attempting to write bytes that are not valid UTF-8 will return
/// an error.
/// When operating in a console, the Windows implementation of this stream decodes bytes
/// as UTF-8, replacing malformed sequences with the Unicode replacement character (U+FFFD).
///
/// In a process with a detached console, such as one using
/// `#![windows_subsystem = "windows"]`, or in a child process spawned from such a process,
Expand Down Expand Up @@ -659,9 +657,8 @@ static STDOUT: OnceLock<ReentrantLock<RefCell<LineWriter<StdoutRaw>>>> = OnceLoc
///
/// ### Note: Windows Portability Considerations
///
/// When operating in a console, the Windows implementation of this stream does not support
/// non-UTF-8 byte sequences. Attempting to write bytes that are not valid UTF-8 will return
/// an error.
/// When operating in a console, the Windows implementation of this stream decodes bytes
/// as UTF-8, replacing malformed sequences with the Unicode replacement character (U+FFFD).
///
/// In a process with a detached console, such as one using
/// `#![windows_subsystem = "windows"]`, or in a child process spawned from such a process,
Expand Down Expand Up @@ -882,9 +879,8 @@ impl fmt::Debug for StdoutLock<'_> {
///
/// ### Note: Windows Portability Considerations
///
/// When operating in a console, the Windows implementation of this stream does not support
/// non-UTF-8 byte sequences. Attempting to write bytes that are not valid UTF-8 will return
/// an error.
/// When operating in a console, the Windows implementation of this stream decodes bytes
/// as UTF-8, replacing malformed sequences with the Unicode replacement character (U+FFFD).
///
/// In a process with a detached console, such as one using
/// `#![windows_subsystem = "windows"]`, or in a child process spawned from such a process,
Expand All @@ -903,9 +899,8 @@ pub struct Stderr {
///
/// ### Note: Windows Portability Considerations
///
/// When operating in a console, the Windows implementation of this stream does not support
/// non-UTF-8 byte sequences. Attempting to write bytes that are not valid UTF-8 will return
/// an error.
/// When operating in a console, the Windows implementation of this stream decodes bytes
/// as UTF-8, replacing malformed sequences with the Unicode replacement character (U+FFFD).
///
/// In a process with a detached console, such as one using
/// `#![windows_subsystem = "windows"]`, or in a child process spawned from such a process,
Expand All @@ -924,9 +919,8 @@ pub struct StderrLock<'a> {
///
/// ### Note: Windows Portability Considerations
///
/// When operating in a console, the Windows implementation of this stream does not support
/// non-UTF-8 byte sequences. Attempting to write bytes that are not valid UTF-8 will return
/// an error.
/// When operating in a console, the Windows implementation of this stream decodes bytes
/// as UTF-8, replacing malformed sequences with the Unicode replacement character (U+FFFD).
///
/// In a process with a detached console, such as one using
/// `#![windows_subsystem = "windows"]`, or in a child process spawned from such a process,
Expand Down
6 changes: 0 additions & 6 deletions library/std/src/sys/pal/windows/c.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,12 +147,6 @@ pub const HANDLE_FLAG_INHERIT: u32 = cu(windows_sys::HANDLE_FLAG_INHERIT);
pub const STACK_SIZE_PARAM_IS_A_RESERVATION: u32 =
cu(windows_sys::STACK_SIZE_PARAM_IS_A_RESERVATION);

// dwFlags -- WideCharToMultiByte
pub const WC_ERR_INVALID_CHARS: u32 = cu(windows_sys::WC_ERR_INVALID_CHARS);

// dwFlags -- MultiByteToWideChar
pub const MB_ERR_INVALID_CHARS: u32 = cu(windows_sys::MB_ERR_INVALID_CHARS);

// dwFlags -- CreateWaitableTimerExW
pub const CREATE_WAITABLE_TIMER_HIGH_RESOLUTION: u32 =
cu(windows_sys::CREATE_WAITABLE_TIMER_HIGH_RESOLUTION);
Expand Down
2 changes: 0 additions & 2 deletions library/std/src/sys/pal/windows/c/bindings.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2284,7 +2284,6 @@ MAX_PATH
MAXIMUM_REPARSE_DATA_BUFFER_SIZE
MaximumFileInfoByHandleClass
MB_COMPOSITE
MB_ERR_INVALID_CHARS
MB_PRECOMPOSED
MB_USEGLYPHCHARS
MOVEFILE_COPY_ALLOWED
Expand Down Expand Up @@ -2500,7 +2499,6 @@ WakeAllConditionVariable
WakeByAddressAll
WakeByAddressSingle
WakeConditionVariable
WC_ERR_INVALID_CHARS
WideCharToMultiByte
WIN32_FIND_DATAW
WRITE_DAC
Expand Down
2 changes: 0 additions & 2 deletions library/std/src/sys/pal/windows/c/windows_sys.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2985,7 +2985,6 @@ pub struct M128A {
pub const MAXIMUM_REPARSE_DATA_BUFFER_SIZE: i32 = 16384;
pub const MAX_PATH: i32 = 260;
pub const MB_COMPOSITE: i32 = 2;
pub const MB_ERR_INVALID_CHARS: i32 = 8;
pub const MB_PRECOMPOSED: i32 = 1;
pub const MB_USEGLYPHCHARS: i32 = 4;
pub const MOVEFILE_COPY_ALLOWED: i32 = 2;
Expand Down Expand Up @@ -3351,7 +3350,6 @@ pub const WAIT_FAILED: u32 = 4294967295;
pub const WAIT_IO_COMPLETION: i32 = 192;
pub const WAIT_OBJECT_0: i32 = 0;
pub const WAIT_TIMEOUT: i32 = 258;
pub const WC_ERR_INVALID_CHARS: i32 = 128;
#[repr(C)]
#[derive(Clone, Copy)]
pub struct WIN32_FIND_DATAW {
Expand Down
Loading
Loading