Repository navigation
Fix diagnostic::on_unknown format placeholder for paths in expressions and type paths - #164178
Merged
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @dingxiangfei2009. Use Why was this reviewer chosen?The reviewer was selected based on:
|
6 of 7 tasks
This comment was marked as outdated.
This comment was marked as outdated.
mu001999
reviewed
Oct 14, 2026
mejrs
force-pushed
the
on_unknown-mod-names
branch
from
October 14, 2026 07:31
c3ecb92 to
f76d613
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
mu001999
approved these changes
Oct 14, 2026
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Oct 14, 2026
…1999 Fix `diagnostic::on_unknown` format placeholder for paths in expressions and type paths See rust-lang#163636 (comment) for context
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Oct 14, 2026
…1999 Fix `diagnostic::on_unknown` format placeholder for paths in expressions and type paths See rust-lang#163636 (comment) for context
This was referenced Oct 14, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 14, 2026
…uwer Rollup of 17 pull requests Successful merges: - #162749 (Recover missing `turbofish` for `lifetime` arguments in expression position) - #164165 (Add a new `rustc_show_spans` internal attribute) - #164170 (Prefer WriteConsoleW for stdout on Windows) - #164208 (Implement better resolution for delegation `Self` mapping field) - #164255 (test DSL eagerly handle false constraints) - #163230 (Document zero-sized allocations properly for `Box` and `Vec`) - #163442 (Fix fudging) - #163940 (Parse move exprs as a bottom expr instead of a prefix expr) - #164079 (document some quirks around directory symlinks on Windows) - #164178 (Fix `diagnostic::on_unknown` format placeholder for paths in expressions and type paths) - #164219 (Windows FileExt trait doesn't need to handle ErrorKind::Interrupted; test improvements for same) - #164266 (rustdoc: Improvements for `rustc_must_implement_one_of`) - #164272 (Add regression test for #155977) - #164287 (Add regression test for hang in overlap check with GAT alias) - #164292 (Remove the `span_use_eq_ctxt` lint) - #164301 (fix issue number for feature(unsized_const_params)) - #164309 (point at the opaque when its hidden type cannot be inferred)
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 14, 2026
Rollup merge of #164178 - mejrs:on_unknown-mod-names, r=mu001999 Fix `diagnostic::on_unknown` format placeholder for paths in expressions and type paths See #163636 (comment) for context
josetorrs
pushed a commit
to josetorrs/miri
that referenced
this pull request
Oct 16, 2026
…uwer Rollup of 17 pull requests Successful merges: - rust-lang/rust#162749 (Recover missing `turbofish` for `lifetime` arguments in expression position) - rust-lang/rust#164165 (Add a new `rustc_show_spans` internal attribute) - rust-lang/rust#164170 (Prefer WriteConsoleW for stdout on Windows) - rust-lang/rust#164208 (Implement better resolution for delegation `Self` mapping field) - rust-lang/rust#164255 (test DSL eagerly handle false constraints) - rust-lang/rust#163230 (Document zero-sized allocations properly for `Box` and `Vec`) - rust-lang/rust#163442 (Fix fudging) - rust-lang/rust#163940 (Parse move exprs as a bottom expr instead of a prefix expr) - rust-lang/rust#164079 (document some quirks around directory symlinks on Windows) - rust-lang/rust#164178 (Fix `diagnostic::on_unknown` format placeholder for paths in expressions and type paths) - rust-lang/rust#164219 (Windows FileExt trait doesn't need to handle ErrorKind::Interrupted; test improvements for same) - rust-lang/rust#164266 (rustdoc: Improvements for `rustc_must_implement_one_of`) - rust-lang/rust#164272 (Add regression test for rust-lang/rust#155977) - rust-lang/rust#164287 (Add regression test for hang in overlap check with GAT alias) - rust-lang/rust#164292 (Remove the `span_use_eq_ctxt` lint) - rust-lang/rust#164301 (fix issue number for feature(unsized_const_params)) - rust-lang/rust#164309 (point at the opaque when its hidden type cannot be inferred)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #163636 (comment) for context