Repository navigation
convert non-generic diagnostic attribute placeholders to snake_case - #164269
Merged
Merged
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing cc @jdonszelmann, @JonathanBrouwer Some changes occurred in compiler/rustc_passes/src/check_attr.rs cc @jdonszelmann, @JonathanBrouwer Some changes occurred in compiler/rustc_attr_ir |
rustbot
added
A-attributes
Collaborator
|
r? @mu001999 rustbot has assigned @mu001999. Use Why was this reviewer chosen?The reviewer was selected based on:
|
mejrs
force-pushed
the
snake_case_placeholders
branch
from
October 13, 2026 15:15
ac56d57 to
c70ad62
Compare
6 of 7 tasks
mu001999
reviewed
Oct 13, 2026
mejrs
force-pushed
the
snake_case_placeholders
branch
from
October 13, 2026 16:13
c70ad62 to
8def69b
Compare
mu001999
approved these changes
Oct 13, 2026
Member
Author
|
fwiw you can now approve and bors will automagically wait for green ci :) @bors r=mu001999 |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Oct 13, 2026
…u001999 convert non-generic diagnostic attribute placeholders to snake_case In rust-lang#163636 (comment) there's general consensus that these should be snake_case. There's not consensus about the names, only that they should be snake_case. So I'll leave that for later. (this doesn't affect stable diagnostic attributes)
This was referenced Oct 13, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 13, 2026
…uwer Rollup of 12 pull requests Successful merges: - #164040 (move `BoundVarReplacer` into rustc_type_ir) - #162934 (bootstrap: Let test-float-parse follow --target) - #164269 (convert non-generic diagnostic attribute placeholders to snake_case) - #160050 (Fix a splat legacy demangling display bug) - #163383 (Provide context span pointing at trait/item when talking about assoc items) - #164023 (make `with_post_analysis_normalized` invalidate rigid aliases) - #164041 (Add regression test for dead-code with external trait impl) - #164166 (Ignore thread-related tests for UEFI) - #164229 (Update outdated `hir_attrs` doc) - #164244 (Remove the 'sup' method from 'At' and migrate uses to 'sup_raw') - #164257 (Add transmutability test to cover for superseded PR) - #164263 (Fix expected output for x86-64-sysv64-arg-ext.apple.stderr)
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 14, 2026
Rollup merge of #164269 - mejrs:snake_case_placeholders, r=mu001999 convert non-generic diagnostic attribute placeholders to snake_case In #163636 (comment) there's general consensus that these should be snake_case. There's not consensus about the names, only that they should be snake_case. So I'll leave that for later. (this doesn't affect stable diagnostic attributes)
wasd243
pushed a commit
to wasd243/rust-clippy
that referenced
this pull request
Oct 15, 2026
…uwer Rollup of 12 pull requests Successful merges: - rust-lang/rust#164040 (move `BoundVarReplacer` into rustc_type_ir) - rust-lang/rust#162934 (bootstrap: Let test-float-parse follow --target) - rust-lang/rust#164269 (convert non-generic diagnostic attribute placeholders to snake_case) - rust-lang/rust#160050 (Fix a splat legacy demangling display bug) - rust-lang/rust#163383 (Provide context span pointing at trait/item when talking about assoc items) - rust-lang/rust#164023 (make `with_post_analysis_normalized` invalidate rigid aliases) - rust-lang/rust#164041 (Add regression test for dead-code with external trait impl) - rust-lang/rust#164166 (Ignore thread-related tests for UEFI) - rust-lang/rust#164229 (Update outdated `hir_attrs` doc) - rust-lang/rust#164244 (Remove the 'sup' method from 'At' and migrate uses to 'sup_raw') - rust-lang/rust#164257 (Add transmutability test to cover for superseded PR) - rust-lang/rust#164263 (Fix expected output for x86-64-sysv64-arg-ext.apple.stderr)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #163636 (comment) there's general consensus that these should be snake_case. There's not consensus about the names, only that they should be snake_case. So I'll leave that for later.
(this doesn't affect stable diagnostic attributes)