Skip to content

Remove the 'sub' method from 'At' and migrate to 'sub_raw' - #164303

Open
fallible-algebra wants to merge 1 commit into
rust-lang:mainfrom
fallible-algebra:at-removal/remove-sub
Open

fallible-algebra wants to merge 1 commit into
rust-lang:mainfrom
fallible-algebra:at-removal/remove-sub

Conversation

@fallible-algebra

@fallible-algebra fallible-algebra commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

Continuation of #163978, similar scope to #164244.

@rustbot

rustbot commented Oct 14, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in engine.rs, potentially modifying the public API of ObligationCtxt.

cc @lcnr

changes to the core type system

cc @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 14, 2026
@rustbot

rustbot commented Oct 14, 2026

Copy link
Copy Markdown
Collaborator

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 77 candidates
  • Random selection from 18 candidates

@fallible-algebra

Copy link
Copy Markdown
Member Author

r? lcnr

@rustbot rustbot assigned lcnr and unassigned jieyouxu Oct 14, 2026
@rustbot

rustbot commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants