Repository navigation
Rollup of 5 pull requests - #164609
Open
tgross35 wants to merge 10 commits into
Open
Rollup of 5 pull requests#164609tgross35 wants to merge 10 commits into
tgross35 wants to merge 10 commits into
Conversation
… it is always in the code
References inside a MaybeDangling doesn't have to satisfy any memory-depended validity properties. SROA cannot rewrite operations in terms of an inner type, which might require it.
To my understanding, this group was needed prior to the libs team refactor when we had people doing library reviews that weren't actually on T-libs. Since the refactor, everybody here is on T-libs so we should be able to use that default list for reviews. `set-team-rotation-mode` can be used by anybody who wants to opt out.
Exclude MaybeDangling like types from SROA References inside a MaybeDangling doesn't have to satisfy any memory-depended validity properties. SROA cannot rewrite operations in terms of an inner type, which might require it. Fixes rust-lang#164176.
…dr, r=JohnTitor
update {Ipv4Addr,Ipv6Addr}::is_global to match IANA registries
related issue: rust-lang#27709
updates these methods to match IANA registires:
https://www.iana.org/assignments/iana-ipv4-special-registry
https://www.iana.org/assignments/iana-ipv6-special-registry
…r=lolbinarycat [rustdoc] Add the Dyn Compatibility heading all the time in the sidebar since it is always in the doc The 3 first commits come from rust-lang#164266. While working on it, I realized that even though we added a condition for the sidebar heading, we always have: <img width="520" height="146" alt="image" src="https://github.com/user-attachments/assets/94a7c109-6cc0-4a37-831b-7e40a06f44a4" /> So there should be a heading to reflect it. r? @Urgau
…=Kivooeo Revert "Remove indirection for `Expr` in `Body`" This reverts rust-lang#164047 Not a clean revert, but only trivial changes needed. Reverted because there was no perf gain, it broke the input-stats test, and another approach discussed in the original PR is preferable r? nnethercote
…mulacrum triagebot: Delete the libs ad-hoc group To my understanding, this group was needed prior to the libs team refactor when we had people doing library reviews that weren't actually on T-libs. Since the refactor, everybody here is on T-libs so we should be able to use that default list for reviews. `set-team-rotation-mode` can be used by anybody who wants to opt out.
rustbot
added
A-meta
Member
Author
|
@bors r+ force rollup=never p=5 |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Contributor
|
⌛ Testing commit 5d657be with merge 39b126b... Workflow: https://github.com/rust-lang/rust/actions/runs/39364456261 |
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 20, 2026
Rollup of 5 pull requests Successful merges: - #164568 (Exclude MaybeDangling like types from SROA) - #163771 (update {Ipv4Addr,Ipv6Addr}::is_global to match IANA registries) - #164268 ([rustdoc] Add the Dyn Compatibility heading all the time in the sidebar since it is always in the doc) - #164581 (Revert "Remove indirection for `Expr` in `Body`") - #164606 (triagebot: Delete the libs ad-hoc group)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
ExprinBody" #164581 (Revert "Remove indirection forExprinBody")r? @ghost
Create a similar rollup