Skip to content
Navigation Menu
Sign in
Appearance settings
Platform
AI CODE CREATION
GitHub Copilot
Write better code with AI
GitHub Copilot app
Direct agents from issue to merge
MCP Registry
Integrate external tools
DEVELOPER WORKFLOWS
Actions
Automate any workflow
Codespaces
Instant dev environments
Issues
Plan and track work
Code Review
Manage code changes
Code Quality
Enforce quality at merge
APPLICATION SECURITY
GitHub Advanced Security
Find and fix vulnerabilities
Code security
Secure your code as you build
Secret protection
Stop leaks before they start
EXPLORE
Why GitHub
Documentation
Blog
Changelog
Marketplace
View all features
Solutions
BY COMPANY SIZE
Enterprises
Small and medium teams
Startups
Nonprofits
BY USE CASE
App Modernization
DevSecOps
DevOps
CI/CD
View all use cases
BY INDUSTRY
Healthcare
Financial services
Manufacturing
Government
View all industries
View all solutions
Resources
EXPLORE BY TOPIC
AI
Software Development
DevOps
Security
View all topics
EXPLORE BY TYPE
Customer stories
Events & webinars
Ebooks & reports
Business insights
GitHub Skills
SUPPORT & SERVICES
Documentation
Customer support
Community forum
Trust center
Partners
View all resources
Open Source
COMMUNITY
GitHub Sponsors
Fund open source developers
PROGRAMS
Security Lab
Maintainer Community
GitHub Stars
Archive Program
REPOSITORIES
Topics
Trending
Collections
Enterprise
ENTERPRISE SOLUTIONS
Enterprise platform
AI-powered developer platform
AVAILABLE ADD-ONS
GitHub Advanced Security
Enterprise-grade security features
Copilot for Business
Enterprise-grade AI features
Premium Support
Enterprise-grade 24/7 support
Pricing
Search
/
Sign in
Sign up
Appearance settings
You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
Dismiss alert
{{ message }}
rust-lang
/
rust
Public
Uh oh!
There was an error while loading.
Please reload this page
.
Notifications
You must be signed in to change notification settings
Fork
17.1k
Star
119k
Code
Issues
5k+
Pull requests
1.4k
Actions
Projects
Security and quality
6
Insights
Additional navigation options
Code
Issues
Pull requests
Actions
Projects
Security and quality
Insights
Implement object-safety for arbitrary_self_types
- #50173
#50173
Closed
mikeyhew
wants to merge 32 commits into
rust-lang:master
rust-lang/rust:master
from
mikeyhew:arbitrary-self-types-object-safety
mikeyhew/rust:arbitrary-self-types-object-safety
Copy head branch name to clipboard
Conversation
Commits
32
(32)
Checks
Files changed
Closed
Implement object-safety for arbitrary_self_types
#50173
mikeyhew
wants to merge 32 commits into
rust-lang:master
rust-lang/rust:master
from
mikeyhew:arbitrary-self-types-object-safety
mikeyhew/rust:arbitrary-self-types-object-safety
Copy head branch name to clipboard
Commits
Commits on Sep 4, 2018
Make all object-safety methods require a global TyCtxt
mikeyhew
committed
0f0b7cb
View commit details
Copy full SHA for 0f0b7cb
Browse repository at this point
Try to do the CoerceUnsized check for object safety
Show description for 6e05b92
mikeyhew
committed
6e05b92
View commit details
Copy full SHA for 6e05b92
Browse repository at this point
reduce line length to please tidy
mikeyhew
committed
d3af466
View commit details
Copy full SHA for d3af466
Browse repository at this point
do the coerce_unsized check last
Show description for 09202f3
mikeyhew
committed
09202f3
View commit details
Copy full SHA for 09202f3
Browse repository at this point
only check for object-safety if we have an inference variable
Show description for 0f76082
mikeyhew
committed
0f76082
View commit details
Copy full SHA for 0f76082
Browse repository at this point
remove some `use` declarations that got added in during rebase
mikeyhew
committed
76d3e73
View commit details
Copy full SHA for 76d3e73
Browse repository at this point
Add some log messages to aid in debugging
mikeyhew
committed
ebe1199
View commit details
Copy full SHA for ebe1199
Browse repository at this point
re-bind receiver_ty to avoid escaping regions errors
Show description for 04cbc1d
mikeyhew
committed
04cbc1d
View commit details
Copy full SHA for 04cbc1d
Browse repository at this point
It's the receiver type we're checking, not Self
Show description for 831e821
mikeyhew
committed
831e821
View commit details
Copy full SHA for 831e821
Browse repository at this point
allow `self: Self` as a special case for backward-compat
mikeyhew
committed
e5ca14c
View commit details
Copy full SHA for e5ca14c
Browse repository at this point
keep receiver_ty behind a Binder always
Show description for 1509275
mikeyhew
committed
1509275
View commit details
Copy full SHA for 1509275
Browse repository at this point
call liberate_late_bound_regions on receiver_ty
Show description for 9cbce68
mikeyhew
committed
9cbce68
View commit details
Copy full SHA for 9cbce68
Browse repository at this point
fix bug when trait arguments appear in `receiver_ty`
Show description for e3b3167
mikeyhew
committed
e3b3167
View commit details
Copy full SHA for e3b3167
Browse repository at this point
update object-safety ui test for new object-safety rules
mikeyhew
committed
478763b
View commit details
Copy full SHA for 478763b
Browse repository at this point
create receiver_substs using the method's DefId
Show description for b31b0f9
mikeyhew
committed
b31b0f9
View commit details
Copy full SHA for b31b0f9
Browse repository at this point
update some compile-fail tests
Show description for 3e8c5bc
mikeyhew
committed
3e8c5bc
View commit details
Copy full SHA for 3e8c5bc
Browse repository at this point
Add the CoerceSized trait
Show description for a63a201
mikeyhew
committed
a63a201
View commit details
Copy full SHA for a63a201
Browse repository at this point
switch from using CoerceUnsized to CoerceSized for the object-safety check
mikeyhew
committed
2598c1f
View commit details
Copy full SHA for 2598c1f
Browse repository at this point
update comments and fix bug in object_safety.rs
Show description for c236af3
mikeyhew
committed
c236af3
View commit details
Copy full SHA for c236af3
Browse repository at this point
update code comments in object-safety.rs
mikeyhew
committed
ffcadd4
View commit details
Copy full SHA for ffcadd4
Browse repository at this point
update doc comments and fix tidy lints
mikeyhew
committed
f85e838
View commit details
Copy full SHA for f85e838
Browse repository at this point
update object_safety module-level documentation
mikeyhew
committed
85b25a6
View commit details
Copy full SHA for 85b25a6
Browse repository at this point
use [X => Y] instead of [X -> Y] for substitution notation
mikeyhew
committed
39e13ae
View commit details
Copy full SHA for 39e13ae
Browse repository at this point
address nit about `{` being on the wrong line
mikeyhew
committed
9bfb39d
View commit details
Copy full SHA for 9bfb39d
Browse repository at this point
add ICE message explaining that custom receivers dynamic dispatch is not implemented yet
mikeyhew
committed
6b14a12
View commit details
Copy full SHA for 6b14a12
Browse repository at this point
Finish updating ui tests
Show description for 2739801
mikeyhew
committed
2739801
View commit details
Copy full SHA for 2739801
Browse repository at this point
Move CoerceSized from marker to ops
Show description for e972b2b
mikeyhew
committed
e972b2b
View commit details
Copy full SHA for e972b2b
Browse repository at this point
Add a test with pointers and wrappers
Show description for 3c6fcde
mikeyhew
committed
3c6fcde
View commit details
Copy full SHA for 3c6fcde
Browse repository at this point
fix issue number for coerce_sized feature
Show description for 01d0a2e
mikeyhew
committed
01d0a2e
View commit details
Copy full SHA for 01d0a2e
Browse repository at this point
Commits on Sep 5, 2018
Add a positive test using stdlib pointers
Show description for ad8f4c0
mikeyhew
committed
ad8f4c0
View commit details
Copy full SHA for ad8f4c0
Browse repository at this point
Undo submodule changes in a63a201ba5f543ddd858bb65881d7e696fde6707
mikeyhew
committed
ac7677f
View commit details
Copy full SHA for ac7677f
Browse repository at this point
Commits on Sep 6, 2018
remove stray newline
mikeyhew
committed
c5a8553
View commit details
Copy full SHA for c5a8553
Browse repository at this point
You can’t perform that action at this time.