Refactor pattern-matching usefulness algorithm - #65160

Closed

Nadrieril wants to merge 87 commits into

rust-lang:masterfrom

Nadrieril:refactor-usefulness

Commits on Oct 18, 2019

Run `rustfmt`
Nadrieril
committed
c9b33ee
Remove mention of old slice pattern syntax
Nadrieril
committed
3ea9c9c
Clarify and fix the explanation of the algorithm
Nadrieril
committed
f983460
Abstract out pattern stacks to make the code more legible
Nadrieril
committed
77e3a95
Remove some redundancy
Nadrieril
committed
e1b7627
Remove duplicate logic in compute_missing_constructors
Nadrieril
committed
a075db8
Extract constructor application as a Constructor method
Nadrieril
committed
7ee9cb7
Refactor "wild constructor" construction
Nadrieril
committed
a150d97
Clarify some variable names
Nadrieril
committed
f0e8c78
`specialize` conceptually operates on a single pattern
Nadrieril
committed
8a2274b
Wording
Nadrieril
committed
0f5e02e
Add some slice-pattern exhaustiveness tests
Nadrieril
committed
c95b7ae
Rename Constructor::Slice to FixedLenSlice
Nadrieril
committed
ea3fe4e
IntRange::from_pat is redundant with pat_constructors
Nadrieril
committed
d4cc125
split_grouped_constructors only needs access to the list of used constructors
Nadrieril
committed
501cf3a
Share computation of used_ctors
Nadrieril
committed
b2ae93c
Rework the exhaustiveness algorithm to better integrate meta-constructors
Nadrieril
committed
89df721
Define a MissingConstructors struct for cleanliness
Nadrieril
committed
1bd18d2
Move is_non_exhaustive into MissingConstructors
Nadrieril
committed
ad28919
Allow Constructor::apply to return more than one pattern
Nadrieril
committed
ec57a89
Define MissingConstructors meta-constructor and use it for witness reconstruction
Nadrieril
committed
6d9a35d
Match constructor first instead of type first in various functions
Nadrieril
committed
6e392f0
Move constructor_sub_pattern_tys into wildcard_subpatterns
Nadrieril
committed
d9871b8
Replace wildcard-specific code paths with generalized specialization
Nadrieril
committed
cf90304
Factor out some bits
Nadrieril
committed
931d7a9
Extract constructor splitting as a Constructor method
Nadrieril
committed
142df8b
Rename pop_constructor back to specialize
Nadrieril
committed
cb4715d
Add Wildcard meta-constructor
Nadrieril
committed
a1b3800
pat_constructors now returns Wildcard when relevant
Nadrieril
committed
6337864
Avoid allocating in the common case of a single pattern
Nadrieril
committed
c0359ce
Invert condition for clarity
Nadrieril
committed
33273f2
Clarify handling of uninhabited types
Nadrieril
committed
cb3452c
Gather together usefulness tests
Nadrieril
committed
ad78eff
MatchCheckCtxt::byte_array_map is unused since 7df1d9f6564cafca3758e5d629920c02df526989
Nadrieril
committed
a91cdd4
No need to mutate MatchCheckCtxt anymore
Nadrieril
committed
8e89f3c
Add comment about non_exhaustive feature
Nadrieril
committed
9ae4c52
Use Wildcard instead of MissingConstructors when relevant
Nadrieril
committed
b3de6fd
Make IntRange::subtract_from work on a single constructor
Nadrieril
committed
4be3802
Factor out constructor subtraction
Nadrieril
committed
d12b172
subtract_meta_constructor: match on constructor first
Nadrieril
committed
2687140
Extract constructor_intersects_pattern function
Nadrieril
committed
1f8d93c
Inline constructor_covered_by_range and IntRange::from_pat
Nadrieril
committed
1b65bec
Use question mark instead of custom macro
Nadrieril
committed
12bb3b7
Regroup similar code paths
Nadrieril
committed
022c620
Add a few more slice pattern usefulness tests
Nadrieril
committed
0ab764b
Add variable-length slice metaconstructor
Nadrieril
committed
956838d
Don't use max_slice_length when subtracting from VarLenSlice
Nadrieril
committed
1793ad5
Faster code path for subtracting from FixedLenSlice
Nadrieril
committed
527fe65
Faster code path for subtracting from VarLenSlice
Nadrieril
committed
0d58ead
Make exhaustiveness error message more consistent for slice patterns
Nadrieril
committed
0b353b3
Prepare return types for or-patterns
Nadrieril
committed
cf4dc88
MissingConstructors should not be compared for equality, but we need the impl
Nadrieril
committed
1e43487
Add example run of the algorithm
Nadrieril
committed
c8ac41e
Tidy up
Nadrieril
committed
244ac8d
Store both prefix and suffix length in VarLenSlice
Nadrieril
committed
ad09cc5
max_slice_length only needs to look at constructors
Nadrieril
committed
47ee628
Inline max_slice_length
Nadrieril
committed
c6d1cad
Add some test cases
Nadrieril
committed
0c0fe9f
Splitting variable-length slices now respects the required invariant
Nadrieril
committed
6b4426a
PatCtxt is not useful anymore
Nadrieril
committed
72c3a68
Cleanup comments
Nadrieril
committed
f5d833f
Store Const in ConstantRange
Nadrieril
committed
94227f5
Cleanup constructor_intersects_pattern
Nadrieril
committed
60021ce
Implement nnethercote's suggestion
Nadrieril
committed
3d0945d
Implement Centril's suggestion
Nadrieril
committed
5badbb7
Incorporate varkor's review
Nadrieril
committed
defc66d
Be more consistent in terminology
Nadrieril
committed
d8b71d4
Move range exhaustiveness check to IntRange::intersection
Nadrieril
committed
66dac52
Introduce IntRange meta-constructor
Nadrieril
committed
b85e4be
We no longer construct any ConstantValue or ConstantRange for non-integral types
Nadrieril
committed
eea0b79
Remove some unnecessary conversions between Constructor and IntRange
Nadrieril
committed
34b0774
Ungate improved slice patterns diagnostics
Nadrieril
committed
087adfe
Simplify slice subtraction as suggested by arielb1
Nadrieril
committed
a66dcd5
Rewrite constructor_intersects_pattern as a match
Nadrieril
committed
a2624f2
Remove unnecessary Const conversion
Nadrieril
committed
79efdb4
Clarify why the naive algorithm may not terminate
Nadrieril
committed
1f6a5a5
Remove unneeded lifetime extensions
Nadrieril
committed
455095a
Use special `Captures` trait to solve issues with impl Iterator
Nadrieril
committed
d379a43
`pat_constructors` doesn't need a `ty` parameter
Nadrieril
committed
1de1683
Extract head constructors construction
Nadrieril
committed
3aa5fb3
Name the field of PatStack
Nadrieril
committed
c956c65
Cache `pat_constructors` invocations
Nadrieril
committed
368c71b
Compute constructors on PatStack construction
Nadrieril
committed
6df1815
Restore performance
Nadrieril
committed
ed3ea67
Don't rebuild the same matrix twice
Nadrieril
committed
9c3682f
Don't use SmallVec when we could use Option
Nadrieril
committed
b052036
Integrate comment fixes suggested by arielb1
Nadrieril
committed
fd3ec66