Skip to content
Navigation Menu
Sign in
Appearance settings
Platform
AI CODE CREATION
GitHub Copilot
Write better code with AI
GitHub Copilot app
Direct agents from issue to merge
MCP Registry
Integrate external tools
DEVELOPER WORKFLOWS
Actions
Automate any workflow
Codespaces
Instant dev environments
Issues
Plan and track work
Code Review
Manage code changes
Code Quality
Enforce quality at merge
APPLICATION SECURITY
GitHub Advanced Security
Find and fix vulnerabilities
Code security
Secure your code as you build
Secret protection
Stop leaks before they start
EXPLORE
Why GitHub
Documentation
Blog
Changelog
Marketplace
View all features
Solutions
BY COMPANY SIZE
Enterprises
Small and medium teams
Startups
Nonprofits
BY USE CASE
App Modernization
DevSecOps
DevOps
CI/CD
View all use cases
BY INDUSTRY
Healthcare
Financial services
Manufacturing
Government
View all industries
View all solutions
Resources
EXPLORE BY TOPIC
AI
Software Development
DevOps
Security
View all topics
EXPLORE BY TYPE
Customer stories
Events & webinars
Ebooks & reports
Business insights
GitHub Skills
SUPPORT & SERVICES
Documentation
Customer support
Community forum
Trust center
Partners
View all resources
Open Source
COMMUNITY
GitHub Sponsors
Fund open source developers
PROGRAMS
Security Lab
Maintainer Community
GitHub Stars
Archive Program
REPOSITORIES
Topics
Trending
Collections
Enterprise
ENTERPRISE SOLUTIONS
Enterprise platform
AI-powered developer platform
AVAILABLE ADD-ONS
GitHub Advanced Security
Enterprise-grade security features
Copilot for Business
Enterprise-grade AI features
Premium Support
Enterprise-grade 24/7 support
Pricing
Search
/
Sign in
Sign up
Appearance settings
You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
Dismiss alert
{{ message }}
rust-lang
/
rust
Public
Uh oh!
There was an error while loading.
Please reload this page
.
Notifications
You must be signed in to change notification settings
Fork
17.6k
Star
120k
Code
Issues
5k+
Pull requests
1.4k
Actions
Projects
Security and quality
6
Insights
Additional navigation options
Code
Issues
Pull requests
Actions
Projects
Security and quality
Insights
Refactor slice pattern usefulness checking
- #66129
#66129
Merged
bors
merged 18 commits into
rust-lang:master
rust-lang/rust:master
from
Nadrieril:refactor-slice-pat-usefulness
Nadrieril/rust:refactor-slice-pat-usefulness
Copy head branch name to clipboard
Nov 12, 2019
Conversation
Commits
18
(18)
Checks
Files changed
Merged
Refactor slice pattern usefulness checking
#66129
bors
merged 18 commits into
rust-lang:master
rust-lang/rust:master
from
Nadrieril:refactor-slice-pat-usefulness
Nadrieril/rust:refactor-slice-pat-usefulness
Copy head branch name to clipboard
Commits
Commits on Nov 5, 2019
Add some slice-pattern exhaustiveness tests
Nadrieril
committed
4dc5697
View commit details
Copy full SHA for 4dc5697
Browse repository at this point
Rename Constructor::Slice to FixedLenSlice
Nadrieril
committed
235b379
View commit details
Copy full SHA for 235b379
Browse repository at this point
Match on self first in subtract_constructor
Nadrieril
committed
d2b7711
View commit details
Copy full SHA for d2b7711
Browse repository at this point
Add special variable-length slice constructor
Nadrieril
committed
e092a17
View commit details
Copy full SHA for e092a17
Browse repository at this point
Simpler code path for subtracting from FixedLenSlice
Nadrieril
committed
909ec37
View commit details
Copy full SHA for 909ec37
Browse repository at this point
Don't use max_slice_length when subtracting from VarLenSlice
Show description for b669730
Nadrieril
committed
b669730
View commit details
Copy full SHA for b669730
Browse repository at this point
Make exhaustiveness error message more consistent for slice patterns
Show description for 65bc67e
Nadrieril
committed
65bc67e
View commit details
Copy full SHA for 65bc67e
Browse repository at this point
Add some test cases
Nadrieril
committed
58de9d9
View commit details
Copy full SHA for 58de9d9
Browse repository at this point
Store both prefix and suffix length in VarLenSlice
Nadrieril
committed
d7044f2
View commit details
Copy full SHA for d7044f2
Browse repository at this point
pat_constructors returns at most one constructor
Show description for 149792b
Nadrieril
committed
149792b
View commit details
Copy full SHA for 149792b
Browse repository at this point
Inline max_slice_length
Show description for d582ed5
Nadrieril
committed
d582ed5
View commit details
Copy full SHA for d582ed5
Browse repository at this point
Use VarLenSlice consistently when splitting constructors
Show description for f774eb6
Nadrieril
committed
f774eb6
View commit details
Copy full SHA for f774eb6
Browse repository at this point
Move a few more tests to the usefulness/ folder
Nadrieril
committed
9531787
View commit details
Copy full SHA for 9531787
Browse repository at this point
Commits on Nov 6, 2019
Apply suggestions from code review
Show description for 816aee2
Nadrieril
and
Centril
committed
816aee2
View commit details
Copy full SHA for 816aee2
Browse repository at this point
Factor out constructing a new wildcard pattern
Nadrieril
committed
7514c48
View commit details
Copy full SHA for 7514c48
Browse repository at this point
Split slice-patterns test as suggested by Centril
Nadrieril
committed
098974d
View commit details
Copy full SHA for 098974d
Browse repository at this point
Commits on Nov 10, 2019
Inline constructor_sub_pattern_tys
Show description for 369a351
Nadrieril
committed
369a351
View commit details
Copy full SHA for 369a351
Browse repository at this point
tidy
Nadrieril
committed
fd9921b
View commit details
Copy full SHA for fd9921b
Browse repository at this point
You can’t perform that action at this time.