Add DocJson profile for benchmarking JSON rustdoc output - #2156
Merged
Merged
Conversation
nnethercote
reviewed
Jun 11, 2025
nnethercote
reviewed
Jun 11, 2025
nnethercote
reviewed
Jun 11, 2025
nnethercote
reviewed
Jun 11, 2025
Kobzol
force-pushed
the
rustdoc-json-perf-check
branch
from
June 11, 2025 06:03
af7ed5b to
2f75b4e
Compare
nnethercote
approved these changes
Jun 11, 2025
nnethercote
left a comment
nnethercote
left a comment
Contributor
There was a problem hiding this comment.
Looks good, just a few nits.
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revival of #1512 (CC @GuillaumeGomez).
It won't run on PRs right now, but it at least simplifies local benchmarking. In the future we will hopefully have a way of also running it on PRs on demand.