[yilin0518]

I open the same PR in Rust repo: remove redundant unsafe, except that that PR modfies a call site of __yield(). Please refer to that PR for concrete information.

[rustbot]

r? @adamgemmell

rustbot has assigned @adamgemmell.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: @Amanieu, @adamgemmell, @davidtwco, @folkertdev, @sayantn
• @Amanieu, @adamgemmell, @davidtwco, @folkertdev, @sayantn expanded to Amanieu, adamgemmell, davidtwco, folkertdev, sayantn
• Random selection from Amanieu, adamgemmell, davidtwco, folkertdev, sayantn

[yilin0518]

The CI failed but I didn't change anything about crate::intrinsics::abort(). I don't know the reason.

[adamgemmell]

The intrinsic was renamed upstream in Rust and the changes have now been synced across to this repo, so CI should pass if you give it a rebase.

[adamgemmell]

I think this cfg block is the correct one for all the hints except sevl (for which it sounds like LLVM requires v8 for). Could you apply it to the other intrinsics please?

The hint space encoding mechanism was introduced in v6k, v6t2 or v6 on m class.

View changes since the review

[yilin0518]

I think this cfg block is the correct one for all the hints except sevl (for which it sounds like LLVM requires v8 for). Could you apply it to the other intrinsics please?

The hint space encoding mechanism was introduced in v6k, v6t2 or v6 on m class.

View changes since the review

I can do it, thank you for your review!

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[yilin0518]

This PR is still under discussion in Zulip: https://rust-lang.zulipchat.com/#narrow/channel/219381-t-libs/topic/Safety.20requirements.20of.20ARM.20hint.20APIs/with/629947023

So I think it is better to have a look @adamgemmell

[yilin0518]

@adamgemmell This PR has been approved by Rust member. So should I close this PR?

[adamgemmell]

Closing as rust-lang/rust#163918 has been merged. Thanks for working on this!