Breaking: Improve pm1 enable registers control - #326
Open
ChocolateLoverRaj wants to merge 2 commits into
Open
Conversation
Now set/clear all event flags in one write. This means no read is necessary and also eliminates that cause of race conditions.
Contributor
|
Too me, this looks like a sensible extension of #325 - I (or Isaac) will give it a better look once #325 lands. Since the two PRs cover a lot of the same ground, I wondered: have you seen the Stacked PRs feature that released recently? Don't feel like you have to use it, but also feel free to if you do like it. |
Contributor
Author
|
I didn't know about stacked PRs until now. I will probably wait until the web UI has stacked PR creation since it seems to be gh CLI only rn. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically an extension of #325 , but does some breaking changes. Fixes #327 .