Fix a couple issues with end tags - #332
Conversation
The end tag value itself should be 0x79, that is tag 0x78 | 1 (length).
When concatenating resource templates, only the descriptors themselves should be concatenated, not their end tags.
|
Good spot @dewyatt, thanks for the PR. The code looks good to me but it's broken a test - would you fix that and then I'll merge? One other thing - have you come across a use of the ConcatRes op in the wild? If so, any chance you could point me at an acpidump of it? I'll try and extract a minimal set of ASL from it to use as a regression test. |
Disregard that - looks like it might be broken in |
|
I apologize for not adding tests, just a little busy. I can add some later if you don't. Yes, this was a result of an encounter with ConcatenateResTemplate in the wild. Here is the full ACPI table dump (sans MSDM): |
|
I tried re-running the tests but they fail again - I think Isaac saw this problem before, and I'm 99% confident that the tests will work after merging. 🤞
If you get round to it, that'd be great - feel free to offer anything you think is worthwhile. No worries if not. I'll probably do some at some point, but it really means at some point rather than sometime soon 😆
Awesome - always cool to hear about the crate being used! Is it a testbed for a hobby OS or something else? |
|
🎉 the tests do indeed work! Thanks again @dewyatt |
Just testing out Redox OS, found my touchpad doesn't work and fell down a rabbit hole writing a driver stack. :P |
2 participants
No description provided.