Add I2C and GPIO resource descriptors - #333
Conversation
Only I2C for now, but trivial to expand support.
martin-hughes
left a comment
There was a problem hiding this comment.
Thanks for this PR as well @dewyatt - it looks fundamentally sound to me.
Just a few nitpicks really, and a couple of questions for @IsaacWoods.
There was a problem hiding this comment.
@IsaacWoods should we be comparing the length of the descriptor buffer slices against the value of the length field contained within that slice?
I know there's no memory safety risk of skipping this check, it'd mostly be to avoid an out-of-bounds panic.
There was a problem hiding this comment.
Yes I think the ideal would be for parsing resource descriptors to be entirely panic free (I can't recall if that's the position we're in atm)
|
Thanks @dewyatt for the PR and to @martin-hughes for review. Very happy for this to be merged from my end when questions addressed :) |
No description provided.