Conversation
All other dst_len implementations assert that the reported tag size covers the base size before subtracting; NetworkTag was the only one missing this guard.
The string table is not part of the tag: the tag only stores the physical address (sh_addr) and size of the section holding it, both taken verbatim from the boot information. Make the function unsafe and document the caller's obligations.
All other dst_len implementations assert that the reported tag size covers the base size before subtracting; this one was missing the guard.
Both traits carry soundness-critical contracts that safe code could violate: ref_from_bytes/ref_from_slice materialize &H from raw bytes (a Header type with a niche, e.g. a NonZeroU32 field, leads to an invalid value), and cast/new_boxed derive reference extents from BASE_SIZE/dst_len (a wrong dst_len creates a reference beyond the allocation). Miri confirms both as undefined behavior with purely safe downstream impls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix various UB, identified with claude/fable