Skip to content

Use casual C++ terminology #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teor2345 merged 1 commit into from
Sep 22, 2026
Merged

Use casual C++ terminology #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions cpp-overload-test/src/stdcpp/forward_list.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ impl StdForwardList {
StdForwardList(list)
}

fn const_lvalue_copy(other: &StdForwardList) -> StdForwardList {
fn copy_from(other: &StdForwardList) -> StdForwardList {
let other = other.0 as *const c_void;
let list = unsafe {
cpp!([other as "const std::forward_list<int>*"] -> *mut c_void as "std::forward_list<int>*" {
Expand All @@ -54,7 +54,7 @@ impl StdForwardList {
StdForwardList(list)
}

fn rvalue_copy(other: &mut StdForwardList) -> StdForwardList {
fn move_from(other: &mut StdForwardList) -> StdForwardList {
let other: *mut c_void = other.0;
let list = unsafe {
cpp!([other as "std::forward_list<int>*"] -> *mut c_void as "std::forward_list<int>*" {
Expand Down Expand Up @@ -87,14 +87,12 @@ overload! {

/// Clone a list from a shared reference.
fn new(other: &StdForwardList) -> StdForwardList {
StdForwardList::const_lvalue_copy(other)
StdForwardList::copy_from(other)
}

/// Clone a list from a mutable reference.
/// Some C++ types use this to extend temporary lifetimes or mutate list objects during
/// copy construction.
/// Move list items from a mutable reference into a new list.
fn new(other: &mut StdForwardList) -> StdForwardList {
StdForwardList::rvalue_copy(other)
StdForwardList::move_from(other)
}

// TODO:
Expand Down
Loading