fix: update pywebnn for https://github.com/rustnn/rustnn/pull/260 - #20
Merged
Merged
Conversation
theHamsta
commented
Sep 28, 2026
| .map(|layout| { | ||
| serde_json::from_str(layout).map_err(|_err| { | ||
| pyo3::exceptions::PyValueError::new_err(format!( | ||
| "Invalid filter_layout '{layout}', must be 'iohw' | 'hwoi' | 'ohwi'", |
Contributor
Author
There was a problem hiding this comment.
Previous error message was wrong as it allowed more transposed filter layouts than possible (copied from conv2dfilter layouts?)
Contributor
Author
There was a problem hiding this comment.
this ignores the quotes 🤦
Contributor
Author
There was a problem hiding this comment.
format!("\"{layout}\"") works in a hacky way but ideally RustNN provides the conversion directly
3 of 6 tasks
Contributor
Author
|
A bit strange that we're using git deps here but don't have the lock file checked in. |
theHamsta
marked this pull request as draft
September 28, 2026 16:22
theHamsta
force-pushed
the
fix-filter-options
branch
from
September 28, 2026 16:47
97e89b9 to
55663ee
Compare
theHamsta
marked this pull request as ready for review
October 1, 2026 08:11
mtavenrath
self-requested a review
October 2, 2026 07:34
mtavenrath
approved these changes
Oct 2, 2026
mtavenrath
left a comment
mtavenrath
left a comment
Contributor
There was a problem hiding this comment.
The failure is not related to this change, but added validation to RustNN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible fix for rustnn/rustnn#260
I could also add a TryFrom implementation to RustNN